[Bug 6321] New: Add a 1/4 month frequency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Bug #: 6321 Summary: Add a 1/4 month frequency Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: PATCH-Sent Component: Serials AssignedTo: frederic@tamil.fr ReportedBy: frederic@tamil.fr QAContact: koha-bugs@lists.koha-community.org CC: colin.campbell@ptfs-europe.com There is a 1/3 month frequency but not 1/4 month. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-05-07 06:26:48 UTC --- Created attachment 4054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4054 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tajoli@cilea.it --- Comment #2 from Zeno Tajoli <tajoli@cilea.it> 2011-05-10 15:56:46 UTC --- This bug is present also in 3.2.x -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Stefano Bargioni <bargioni@pusc.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni@pusc.it --- Comment #3 from Stefano Bargioni <bargioni@pusc.it> 2011-05-13 10:01:40 UTC --- (In reply to comment #1)
Created attachment 4054 [details] Proposed patch
Strings 1/4 month (3/year) must be 1/4 months (3/year) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 10:12:13 UTC --- Created attachment 4101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4101 Patch with typo fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 10:13:07 UTC --- (In reply to comment #3)
(In reply to comment #1)
Created attachment 4054 [details] Proposed patch
Strings 1/4 month (3/year) must be 1/4 months (3/year)
Thanks Stefano. Could you sign-off this patch? (Or Colin?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-05-13 10:35:00 UTC --- Sent signoff for amended patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4054|0 |1 is obsolete| | Attachment #4101|0 |1 is obsolete| | --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-06-16 10:47:18 UTC --- Created attachment 4492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4492 Amended signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> 2011-06-16 10:48:44 UTC --- QA needed! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-10 15:44:53 UTC --- QA comment The subscription Add & serials management seems to work well, BUT the subscription-detail page and the opac misses something. The display is 3/week instead of 1/4 month on subscription-detail and The current subscription began on 08/01/2010 and is issued every for 24 months every <<missing periodicity>> for 24 months on OPAC Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4492|0 |1 is obsolete| | --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-09-16 17:01:16 UTC --- Created attachment 5444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5444 Proposed patch Fix error found by Paul. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 --- Comment #11 from Frédéric Demians <frederic@tamil.fr> 2011-10-10 16:36:54 UTC --- Anyone available to sign-off this patch? It still applies on HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-10 20:34:50 UTC --- Created attachment 5830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5830 screenshot I have tested the subscription pattern and there seems to be a little bit of information missing on the brief history view of opac: The current subscription began on 01/01/2011 and is issued every _____ for 9 issues. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5444|0 |1 is obsolete| | --- Comment #13 from Frédéric Demians <frederic@tamil.fr> 2011-10-11 06:01:43 UTC --- Created attachment 5834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5834 Amended proposed patch, with Katrin feedback With a fix to your OPAC display issue, thanks Katrin. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5834|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-11 06:10:02 UTC --- Created attachment 5835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5835 [SIGNED-OFF] Bug 6321 Add a 1/4 months frequency Thanks Stefano Bargioni for the typo fix [2011.09.16] Thanks Paul for catching the display error. [2011.10.11] Thanks Katrin for finding display error on OPAC. Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested prediction pattern and display in OPAC. No problems found. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:40:16 UTC --- Updating version : This ENH could be in Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:59 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Signed Off |Passed QA --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 13:44:19 UTC --- QA Comment: The code for making the distinction between the various frequencies is actually asking for some refactoring. This patch just adds another case, but is easy to read and tested thoroughly, as can be seen above. Marking it as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 Patch Status|Passed QA |Patch Pushed --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-17 16:01:12 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6321 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org