[Bug 11877] New: Eliminate use of deprecated jQuery .live() method
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Bug ID: 11877 Summary: Eliminate use of deprecated jQuery .live() method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org JavaScript in a few templates uses the now-deprecated .live() method. This should be replaced with .on() in preparation for an upgrade of jQuery. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25744&action=edit Bug 11877 - Eliminate use of deprecated jQuery .live() method As of jQuery 1.9 the .live() method has been removed. A few templates contain JavaScript which uses it. It can be easily replaced with .on(). This patch makes the correction. To test, apply the patch and test the following pages: - In the staff client, Administration -> OAI sets configuration: Define mappings for an existing set. You should be able to add rows by clicking the "OR" button. You should be able to delete or clear any line by clicking the "Delete" link. - In the staff client, view the details for any patron and click the "Change password" button: In the change password form click the link to fill the password fields with a random password. This link should work correctly. - If necessary enable OpacRenewalAllowed in system preferences. Log in to the OPAC as a patron who has checkouts. On the patron summary page (opac-user.pl) look for the "renew selected" and "renew all" links at the top of the table of checkouts. Both these links should work correctly. Test in prog and bootstrap themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- FYI, I'll be referring to this page for further updates: http://jquery.com/upgrade-guide/1.9/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 25744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25744 Bug 11877 - Eliminate use of deprecated jQuery .live() method Review of attachment 25744: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11877&attachment=25744) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt @@ +40,4 @@
} return valid; }); + $("body").on("click","#renewselected_link",function(){
IS there a reason to prefer this way instead of: $("#renewselected_link").on("click", function(){ ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> ---
IS there a reason to prefer this way instead of: $("#renewselected_link").on("click", function(){
".click(function(){" is an shortcut for ".on("click",function(){", so most of the time the two are completely interchangeable. In this case we need to use ".on()" because we're attaching an event to an element which has not yet been created. The use of ".on()" quoted above means, "For all existing and future instances of '#renewselected_link' which are descendents of "body," attach this click handler." http://api.jquery.com/on/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- I found a problem with step 2: How to repruduce: Click on "Change password" It displays the form "Change unsername and/or password for e.g. Edna Acosta Field "New username" is filled with usernumber (?): 23529001000463 (Would expect the user name here, not the number - but I think this is not related to this bug?) Then I click on "Click to fill with randoly generated password" Password fields are filled with new value, e.g. 'xcJ' (OK) Then I clear the password fields and click again for password suggestion Result: Password fields stay empty. (Would expect new suggstion.) Console says: "Kein Element gefunden (No element found)" file:///C:/Users/ApDAta/Roaming/Mozilla/Firefox/o1dv3kga.default/clipdat2.rdf I tested with Chrome as well, same behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #6 from Marc Véron <veron@veron.ch> --- Problem with step 2 exists without patch as well. Will sign off on this patch and file an other bug for step 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25744|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 25771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25771&action=edit Bug 11877 - Eliminate use of deprecated jQuery .live() method As of jQuery 1.9 the .live() method has been removed. A few templates contain JavaScript which uses it. It can be easily replaced with .on(). This patch makes the correction. To test, apply the patch and test the following pages: - In the staff client, Administration -> OAI sets configuration: Define mappings for an existing set. You should be able to add rows by clicking the "OR" button. You should be able to delete or clear any line by clicking the "Delete" link. - In the staff client, view the details for any patron and click the "Change password" button: In the change password form click the link to fill the password fields with a random password. This link should work correctly. - If necessary enable OpacRenewalAllowed in system preferences. Log in to the OPAC as a patron who has checkouts. On the patron summary page (opac-user.pl) look for the "renew selected" and "renew all" links at the top of the table of checkouts. Both these links should work correctly. Test in prog and bootstrap themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 25772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25772&action=edit [Signed-off] Bug 11877 - Eliminate use of deprecated jQuery .live() method As of jQuery 1.9 the .live() method has been removed. A few templates contain JavaScript which uses it. It can be easily replaced with .on(). This patch makes the correction. To test, apply the patch and test the following pages: - In the staff client, Administration -> OAI sets configuration: Define mappings for an existing set. You should be able to add rows by clicking the "OR" button. You should be able to delete or clear any line by clicking the "Delete" link. - In the staff client, view the details for any patron and click the "Change password" button: In the change password form click the link to fill the password fields with a random password. This link should work correctly. - If necessary enable OpacRenewalAllowed in system preferences. Log in to the OPAC as a patron who has checkouts. On the patron summary page (opac-user.pl) look for the "renew selected" and "renew all" links at the top of the table of checkouts. Both these links should work correctly. Test in prog and bootstrap themes. Followed test plan. Same behaviour as without patch, i.e. patch OK Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26377&action=edit [PASSED QA] Bug 11877 - Eliminate use of deprecated jQuery .live() method As of jQuery 1.9 the .live() method has been removed. A few templates contain JavaScript which uses it. It can be easily replaced with .on(). This patch makes the correction. To test, apply the patch and test the following pages: - In the staff client, Administration -> OAI sets configuration: Define mappings for an existing set. You should be able to add rows by clicking the "OR" button. You should be able to delete or clear any line by clicking the "Delete" link. - In the staff client, view the details for any patron and click the "Change password" button: In the change password form click the link to fill the password fields with a random password. This link should work correctly. - If necessary enable OpacRenewalAllowed in system preferences. Log in to the OPAC as a patron who has checkouts. On the patron summary page (opac-user.pl) look for the "renew selected" and "renew all" links at the top of the table of checkouts. Both these links should work correctly. Test in prog and bootstrap themes. Followed test plan. Same behaviour as without patch, i.e. patch OK Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, works as described. No Javasript errors found. Note: The buttons on the form show up, even if no item shows the checkbox. In my case the problem was that I had 0 renewals allowed in the circulation rules. Maybe we could hide them, if no item can be renewed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25772|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11877 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x, will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org