[Bug 37618] New: Select patron's, then item's home library by default for pickup location when creating bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Bug ID: 37618 Summary: Select patron's, then item's home library by default for pickup location when creating bookings Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When working with many bookings per day, always selecting the pickup location can become cumbersome. I'd suggest using the patron's home library as a preselection within the pickup library field in the bookings creation modal and to fall back onto the item's home library if the patron's home library is not available. Would you also consider this a sane default? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 [Bug 36120] Add pickup locations to bookings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170235&action=edit Bug 37618: Select patron's, then item's home library by default for pickup location when creating bookings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like the direction here.. will swing back around to it once I've wrapped my head around a few other bits in the bookings tree that are on my list for today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |me@paulderscheid.xyz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170235|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171384&action=edit Bug 37618: Select patron's, then item's home library by default for pickup location when creating bookings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just a rebase so far.. still testing :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171394&action=edit Bug 37618: (follow-up) Inline single use function containsAny and remove definition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171395&action=edit Bug 37618: (follow-up) Remove redundant api call -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Unfortunately there's a bug here that persists the last selected option if neither the patron's nor the item's home library are valid pickup locations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Paul Derscheid from comment #7)
Unfortunately there's a bug here that persists the last selected option if neither the patron's nor the item's home library are valid pickup locations.
Thanks for working this out, Paul! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36120 |37354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 [Bug 36120] Add pickup locations to bookings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37354 [Bug 37354] Bookings should respect circulation rules for max loan periods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171384|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173155&action=edit Bug 37618: Select patron's, then item's home library by default for pickup location when creating bookings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171394|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173156&action=edit Bug 37618: (follow-up) Inline single use function containsAny and remove definition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171395|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173157&action=edit Bug 37618: (follow-up) Remove redundant api call -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This is just a quick rebase and re-arrangement of the bug tree. There's some fixes in bug 37354 around these pickers that pre-exist thing but were only picked up during QA rounds there.. hense the rebase and hope it fixes some of the failure here. I'll be testing again imminently -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 176924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176924&action=edit Bug 37618: (follow-up) Prevent setting of incorrect default if no filtered pickup locations available -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- That last patch does resolve comment #7 in local testing:
Unfortunately there's a bug here that persists the last selected option if neither the patron's nor the item's home library are valid pickup locations.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Bug 37618 depends on bug 37354, which changed state. Bug 37354 Summary: Bookings should respect circulation rules for max loan periods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37354 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173155|0 |1 is obsolete| | --- Comment #15 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180469&action=edit Bug 37618: Select patron's, then item's home library by default for pickup location when creating bookings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173156|0 |1 is obsolete| | --- Comment #16 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180470&action=edit Bug 37618: (follow-up) Inline single use function containsAny and remove definition Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173157|0 |1 is obsolete| | --- Comment #17 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180471&action=edit Bug 37618: (follow-up) Remove redundant api call Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176924|0 |1 is obsolete| | --- Comment #18 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180472&action=edit Bug 37618: (follow-up) Prevent setting of incorrect default if no filtered pickup locations available Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Paul has done a lot of work to convert the bookings modal to a vue island.. that's going to be submitted soon and will supplant this bug.. marking as BLOCKED for now and we'll pull the Vue implimentation into here as soon as we're ready for that submission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37618 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37354 |41129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37354 [Bug 37354] Bookings should respect circulation rules for max loan periods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129 [Bug 41129] Migrate place_booking.js to a Vue island. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org