[Bug 37493] New: Cypress videos and screenshots should be .gitignored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Bug ID: 37493 Summary: Cypress videos and screenshots should be .gitignored Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169705&action=edit Bug 37493: [DONT PUSH] Test only Apply this patch only, run: 1) cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" 2) run `git status`. Notice t/cypress/screenshots/ and t/cypress/videos/ show 3) Apply 2nd patch. Repeat 2). Notice its empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169706&action=edit Bug 37493: Update .gitignore Add t/cypress/screenshots/ Add t/cypress/videos/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169705|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169708&action=edit Bug 37493: [DONT PUSH] Test only - Force test fail Apply this patch only, run: 1) cypress run --spec "t/cypress/integration/flatpickr_spec.ts" 2) run `git status`. Notice t/cypress/screenshots/ and t/cypress/videos/ show 3) Apply 2nd patch. Repeat 2). Notice its empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169706|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169709&action=edit Bug 37493: Update .gitignore Add t/cypress/screenshots/ Add t/cypress/videos/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|minor |trivial Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169708|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 169794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169794&action=edit Bug 37493: [DONT PUSH] Test only - Force test fail Apply this patch only, run: 1) cypress run --spec "t/cypress/integration/flatpickr_spec.ts" 2) run `git status`. Notice t/cypress/screenshots/ and t/cypress/videos/ show 3) Apply 2nd patch. Repeat 2). Notice its empty Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169709|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 169795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169795&action=edit Bug 37493: Update .gitignore Add t/cypress/screenshots/ Add t/cypress/videos/ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates .gitignore so release notes| |that the directories for | |any screenshots and videos | |created by cypress tests | |are ignored by git. The | |directories created are: | |- | |t/cypress/screenshots/ | |- | |t/cypress/videos/ CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- If these files are ignored, won't the space the screenshots and videos take up git* a little large after a while. Or are these removed automatically at some stage when the tests are all successfully run? * A bad pun! 8-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA'd by RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #7)
If these files are ignored, won't the space the screenshots and videos take up git* a little large after a while. Or are these removed automatically at some stage when the tests are all successfully run?
* A bad pun! 8-)
Hm, good question. I guess you will no longer see this files in the git status, so they might be easy to miss. Pedro, can you please comment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot to remove from local branch - pushed to main for now. Waiting for the reply to decide if we want to keep or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #7)
If these files are ignored, won't the space the screenshots and videos take up git* a little large after a while. Or are these removed automatically at some stage when the tests are all successfully run?
* A bad pun! 8-)
I don't believe these will be removed after a while. This was only a tiny enhancement to prevent me from adding videos to commits as I've done in the past, but I'm happy to have this dropped and ignore this locally. (In reply to Katrin Fischer from comment #10)
Forgot to remove from local branch - pushed to main for now. Waiting for the reply to decide if we want to keep or not.
Please note that you have pushed the [DONT PUSH] patch. That'll cause cypress tests to fail: https://github.com/Koha-Community/Koha/commit/0d69fc60904ec6ad95863977d8cdec... Mentioning this to make sure both patches are dropped. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Guess... this was not my best day. I'll revert the DONT PUSH at least right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #12)
Guess... this was not my best day. I'll revert the DONT PUSH at least right now.
Done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Perhaps we add a QA hook to check that files in that space are not included in any commits instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37493 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org