[Bug 21355] New: GetDailyQuotes.t is fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Bug ID: 21355 Summary: GetDailyQuotes.t is fragile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Problems found: - the arithmetic adds an hour to some dates, so if it is run close to midnight, the daily quote will fail - 'quote' attribute is compared, and it doesn't exist. Should be 'text'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Assignee|chris@bigballofwax.co.nz |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78873&action=edit Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00 Tests will fail (Jenkins run #554) if run after 23:00 # Failed test 'Id is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 72. # got: 6 # expected: 8 # Failed test 'Timestamp 2018-09-15 00:44:46 is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 74. # got: '2018-09-14 23:44:46' # expected: '2018-09-15 00:44:46' # Looks like you failed 2 tests of 12. [23:44:46] t/db_dependent/Koha/GetDailyQuote.t Dubious, test returned 2 (wstat 512, 0x200) Adding only 1 second will hugely reduce the risk of failure here. It also updates a useless test (column 'quote' does not exist) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78873|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 78876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78876&action=edit Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00 Tests will fail (Jenkins run #554) if run after 23:00 # Failed test 'Id is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 72. # got: 6 # expected: 8 # Failed test 'Timestamp 2018-09-15 00:44:46 is correct' # at t/db_dependent/Koha/GetDailyQuote.t line 74. # got: '2018-09-14 23:44:46' # expected: '2018-09-15 00:44:46' # Looks like you failed 2 tests of 12. [23:44:46] t/db_dependent/Koha/GetDailyQuote.t Dubious, test returned 2 (wstat 512, 0x200) Adding only 1 second will hugely reduce the risk of failure here. It also updates a useless test (column 'quote' does not exist) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested: - Run: $ sudo date -s 2018-09-15T23:10:00 $ kshell k$ prove t/db_dependent/Koha/GetDailyQuote.t => FAIL: Tests fail as patch author mentions - Apply the patch k$ prove t/db_dependent/Koha/GetDailyQuote.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- :_D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20144 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 [Bug 20144] Test suite is failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21355 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 20144 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org