https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110599&action=edit Bug 26512: Display issue with buttons for OPAC checkout note This patch adds the correct Bootstrap 4 class to the buttons for submitting checkout notes in the OPAC. The markup has been updated to use <button> instead of <a> because of a style conflict with jQueryUI's CSS. To test, apply the patch and enable the AllowCheckoutNotes system preference. - Log in to the OPAC as a patron with checkouts. - On the "Your summary" page, enter some text into a field in the "Notes" column of the checkouts table. - Upon typing in the field a button should appear, "Submit note." - The button should be styled as a green button. - Submit the note. - Make a change to the text in the field. A button should appear, "Submit changes." It should also be styled correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110599|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110624&action=edit Bug 26512: Display issue with buttons for OPAC checkout note This patch adds the correct Bootstrap 4 class to the buttons for submitting checkout notes in the OPAC. The markup has been updated to use <button> instead of <a> because of a style conflict with jQueryUI's CSS. To test, apply the patch and enable the AllowCheckoutNotes system preference. - Log in to the OPAC as a patron with checkouts. - On the "Your summary" page, enter some text into a field in the "Notes" column of the checkouts table. - Upon typing in the field a button should appear, "Submit note." - The button should be styled as a green button. - Submit the note. - Make a change to the text in the field. A button should appear, "Submit changes." It should also be styled correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110624|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110628&action=edit Bug 26512: Display issue with buttons for OPAC checkout note This patch adds the correct Bootstrap 4 class to the buttons for submitting checkout notes in the OPAC. The markup has been updated to use <button> instead of <a> because of a style conflict with jQueryUI's CSS. To test, apply the patch and enable the AllowCheckoutNotes system preference. - Log in to the OPAC as a patron with checkouts. - On the "Your summary" page, enter some text into a field in the "Notes" column of the checkouts table. - Upon typing in the field a button should appear, "Submit note." - The button should be styled as a green button. - Submit the note. - Make a change to the text in the field. A button should appear, "Submit changes." It should also be styled correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if this should be backported - the dependency (Bootstrap 4 update) is not in 20.05. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Cait, You are right, that was a mistake on my part. Reverting this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 Bug 26512 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.