[Bug 11179] New: opac-course-details.pl shows item as available when it is checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Bug ID: 11179 Summary: opac-course-details.pl shows item as available when it is checked out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22659&action=edit Bug 11179 - opac-course-details.pl shows item as available when it is checked out If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue Test Plan: 1) Create a course 2) Add an item to that course 3) Check the item out to a patron 4) View the course details from the opac 5) Note the status says "Available" 6) Apply this patch 7) Repeat step 4 8) Note the status no longer says "Available" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22659|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22950&action=edit [SIGNED-OFF] Bug 11179 - opac-course-details.pl shows item as available when it is checked out If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue Test Plan: 1) Create a course 2) Add an item to that course 3) Check the item out to a patron 4) View the course details from the opac 5) Note the status says "Available" 6) Apply this patch 7) Repeat step 4 8) Note the status no longer says "Available" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22951&action=edit Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22951|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 23012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23012&action=edit Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Bootstrap theme looking so nice. Also the patch works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Works as expected on both OPAC themes. I am just wondering if we should not add a comment in the include file in order to explain why sometimes there is an issue parameter and sometimes not. I think it can be confusing for new calls to this inc. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22950|0 |1 is obsolete| | Attachment #23012|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23020&action=edit Bug 11179 - opac-course-details.pl shows item as available when it is checked out If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue Test Plan: 1) Create a course 2) Add an item to that course 3) Check the item out to a patron 4) View the course details from the opac 5) Note the status says "Available" 6) Apply this patch 7) Repeat step 4 8) Note the status no longer says "Available" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23021&action=edit Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Bootstrap theme looking so nice. Also the patch works. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23021|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23028&action=edit Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Bootstrap theme looking so nice. Also the patch works. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that adds a comment to item-status.inc to describe the parameters it accepts. Thanks, Kyle and Owen! However, the wart in the API that means that item.datedue is not always set, depending on how you retrieve the item, should be fixed. In the long run, it should either never be necessary to supply a separate issues parameter to the template or it should always be necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.3. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org