[Bug 19932] New: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Bug ID: 19932 Summary: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 14546, 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be z3950_search.tt, the template for Z39.50 searches from the cataloging interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70341&action=edit Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939 [Bug 19939] Move cataloging Z39.50 results actions into menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70341|0 |1 is obsolete| | --- Comment #2 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70713&action=edit Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With the patch the save/cancel options are outside of the visible area. (Firefox Quantum 58 on Ubuntu). Without the patch it's ok. Could you take another look? Everything else seems to work perfectly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71284&action=edit Bug 19932: (Follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70713|0 |1 is obsolete| | Attachment #71284|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71334&action=edit [SIGNED-OFF] Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71335&action=edit [SIGNED-OFF] Bug 19932: (Follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71700&action=edit Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308@gmail.com> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71701&action=edit Bug 19932: (follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org