https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92440&action=edit Bug 23492: OPAC search facet header should not be a link at larger browser widths This patch adds some JavaScript-driven "breakpoints" to the OPAC so that on the search results page the "Refine your search" heading has different behaviors depending on whether facets are being displayed as a sidebar. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to the OPAC and resize your browser to be greater than ~ 800px wide. - Perform a catalog search which will return several results. - In the left-hand sidebar of the search results page, the "Refine your search" heading should not be styled like a link. Hovering over it with the mouse should not change the cursor to the pointing-hand. - Narrow your browser window until the sidebar collapses. - The "Refine your search" heading should now be styled as a link, with a right-arrow icon before it. - Clicking it should expand the facets. The icon should change to a down-arrow. - Widen your browser window and test again. - Perform the same tests when starting with a narrow browser window. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Having never signed off on a bug where it is necessary to regenerate the CSS I did this: -Applied patch -regenerated CSS -Tested -git reset --hard origin/master -Re-applied the patch -Signed off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92442|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92447&action=edit Bug 23492: OPAC search facet header should not be a link at larger browser widths This patch adds some JavaScript-driven "breakpoints" to the OPAC so that on the search results page the "Refine your search" heading has different behaviors depending on whether facets are being displayed as a sidebar. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to the OPAC and resize your browser to be greater than ~ 800px wide. - Perform a catalog search which will return several results. - In the left-hand sidebar of the search results page, the "Refine your search" heading should not be styled like a link. Hovering over it with the mouse should not change the cursor to the pointing-hand. - Narrow your browser window until the sidebar collapses. - The "Refine your search" heading should now be styled as a link, with a right-arrow icon before it. - Clicking it should expand the facets. The icon should change to a down-arrow. - Widen your browser window and test again. - Perform the same tests when starting with a narrow browser window. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 23481 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This looks sane enough to me and a quick test is positive.. happy to accept the PQA as is :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.