[Bug 37213] New: Improve breadcrumbs in rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Bug ID: 37213 Summary: Improve breadcrumbs in rotating collections Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com 1. Tools > Rotating collections > New collection 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right: Tools > Rotating collections > Collection " > Edit collection -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 --- Comment #1 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 168214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168214&action=edit Bug 37213: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168214|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 168216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168216&action=edit Bug 37213: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Added Assignee now. Please fill yourself next time :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This looks a bit odd. I would not expect created or deleted to pop up in the breadcrumbs. If something failed, we should have a dialog alert somewhere else. Furthermore there seems to be an issue with: [% WRAPPER breadcrumb_item %] <a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% editColId | uri %]">[% tx("Collection '{collection_title}'", { collection_title = editColTitle }) | html %]</em></a> [% END %] The quoted empty string comes from there. Should the script pass a correct op and record id here instead? If you delete a collection, probably the op should change to new. If you added or updated, we need the record id. Note also that I see an </em> without an opening <em> ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168232&action=edit Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #4)
This looks a bit odd. I would not expect created or deleted to pop up in the breadcrumbs. If something failed, we should have a dialog alert somewhere else.
We do have a dialog alert. The thing which is inconsistent about this page is that there is a "creation success/failure" stage at all. Usually we would redirect to the list of collections in either case, adding a dialog if there was an error. I think these changes are logical given the unusual workflow of having a "success" page.
The quoted empty string comes from there. Should the script pass a correct op and record id here instead? If you delete a collection, probably the op should change to new. If you added or updated, we need the record id.
Note also that I see an </em> without an opening <em> ?
These issues are all unrelated to the changes in the original patc. I've submitted a follow-up to correct them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168216|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 168575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168575&action=edit Bug 37213: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168232|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 168576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168576&action=edit Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Not related to this bug, but I'm not sure that I understand the difference between Tools > Rotating collections and Cataloging > Automation > Stock rotation (when the StockRotation system preference is enabled). Having similar names is a bit confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168575|0 |1 is obsolete| | --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171269&action=edit Bug 37213: Improved breadcrumbs in rotating collections To test: 1. Tools -> Rotating collections -> New collections 2. Add a title and description 3. After adding the new collection notice the breadcrumb isn't right 4. Apply patch 5. Repeat steps 1 and 2 6. After adding the new collection notice the breadcrumb is improved. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168576|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171270&action=edit Bug 37213: (follow-up) Remove stray </em>, make title logic consistent with breadcrumbs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |paul.derscheid@lmscloud.de --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I passed QA on this because the reported bug was fixed. If there's an issue with the unusual pattern I think this should be addressed in a follow-up bug to this one. I hope that's fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.11.x This is minor I propose to not backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the breadcrumbs release notes| |for rotating collections | |and makes them more | |consistent with other | |breadcrumbs (Tools > | |Rotating collections > New | |collection). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 175066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175066&action=edit Screenshot after patch - rotating collection breadcrumbs when editing still incorrect There is still an issue with these breadcrumbs, so another bug is required to fix. For example, if I edit a breadcrumb, I get (see the screenshot attached): Tools > Rotating collections > Collection '' > Edit collection Collection Test 4 updated successfully Return to rotating collections home To replicate on main: 1. Go to Tools > Rotating collections. 2. Add a new collection (+ New collection) . Name: Test 1 . Description: anything you like 3. Results: Breadcrumb: Tools > Rotating collections > Collection created successfully Collection Test 1 added successfully Return to rotating collections home 4. From the list of rotating collections, select Actions > Edit. 5. Change the name to "Test 4". 6. Results: Tools > Rotating collections > Collection '' > Edit collection Collection Test 4 updated successfully Return to rotating collections home -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org