[Bug 19076] New: Renewal via Checkout screen is logged as both a renewal and a checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Bug ID: 19076 Summary: Renewal via Checkout screen is logged as both a renewal and a checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 17708 To recreate: 1 - Enable both issue and renewal logs 2 - Checkout an item to a patron 3 - View the logs - the issue is captured 4 - Checkout the item to the patron again and confirm renewal 5 - Both an issue and a renewal are logged Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 [Bug 17708] Renewal log seems empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65829&action=edit Bug 19076 - unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65830&action=edit Bug 19076 - Move issue logging in AddIssue into condtional clause Currently AddIssue tests if renewal, but logs an issue even if so. This patch moves the logging into the conditional so a log entry is only added if we aren't renewing (as renewals are logged separately) To test: 1 - prove t/db_dependent/Circulation.t - one test should fail 2 - Enable both issue and renewal logs 3 - Checkout an item to a patron 4 - View the logs - the issue is captured 5 - Checkout the item to the patron again and confirm renewal 6 - Both an issue and a renewal are logged 7 - Apply patch 8 Repeat 1-6, tests should pass and only renewal should be logged -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65829|0 |1 is obsolete| | Attachment #65830|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65907&action=edit Bug 19076 - unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65908&action=edit Bug 19076 - Move issue logging in AddIssue into condtional clause Currently AddIssue tests if renewal, but logs an issue even if so. This patch moves the logging into the conditional so a log entry is only added if we aren't renewing (as renewals are logged separately) To test: 1 - prove t/db_dependent/Circulation.t - one test should fail 2 - Enable both issue and renewal logs 3 - Checkout an item to a patron 4 - View the logs - the issue is captured 5 - Checkout the item to the patron again and confirm renewal 6 - Both an issue and a renewal are logged 7 - Apply patch 8 Repeat 1-6, tests should pass and only renewal should be logged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65916&action=edit Bug 19076 - followup - delete fines from additional renewal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cbrannon@cdalibrary.org --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Applies cleanly for me on master, can you pull and retest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 65939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65939&action=edit [SIGNED OFF ] Bug 19076 - followup - delete fines from additional renewal Works as described. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65907|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 66701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66701&action=edit Bug 19076 - unit tests Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65908|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 66702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66702&action=edit Bug 19076 - Move issue logging in AddIssue into condtional clause Currently AddIssue tests if renewal, but logs an issue even if so. This patch moves the logging into the conditional so a log entry is only added if we aren't renewing (as renewals are logged separately) To test: 1 - prove t/db_dependent/Circulation.t - one test should fail 2 - Enable both issue and renewal logs 3 - Checkout an item to a patron 4 - View the logs - the issue is captured 5 - Checkout the item to the patron again and confirm renewal 6 - Both an issue and a renewal are logged 7 - Apply patch 8 Repeat 1-6, tests should pass and only renewal should be logged Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65916|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 66703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66703&action=edit Bug 19076 - followup - delete fines from additional renewal Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Attachment #65939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #8) You only signed off on the last patch, please read the wiki page https://wiki.koha-community.org/wiki/Git_bz_configuration#Bugs_with_more_tha... and/or follow the tutorial: https://wiki.koha-community.org/wiki/Koha_howto -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #5)
Created attachment 65916 [details] [review] Bug 19076 - followup - delete fines from additional renewal
Why this patch here? Sounds like it should be moved somewhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- It should be squashed into unit tests patch, the extra renewal I add for tests added a fine, had to remove that to not break other tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Bug 19076 depends on bug 17708, which changed state. Bug 17708 Summary: Renewal log seems empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependency on bug 17708 which is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org