[Bug 25229] New: Elasticsearch should use the authid (record id) rather than the 001 when returning auth search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Bug ID: 25229 Summary: Elasticsearch should use the authid (record id) rather than the 001 when returning auth search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 0 - Have an environment with both ES and Zebra available 1 - Edit an authority record in the DB to force the 001 and the auth_id to be different update auth_header SET marcxml = REPLACE(marcxml,"1707","potato"); 2 - Reindex Zebra and ES 3 - View the record in zebra (commands below work on kohadevbox sample data) yaz-client unix:/var/run/koha/kohadev/authoritysocket base authorities find "computer program" show 1+14 Note that the relevant record has the auth id in the 001 even though the record doesn't 4 - View the record in Elasticsearch curl -X GET 'localhost:9200/koha_kohadev_authorities/data/1707?pretty' Note the 001 is indexed into local number, but the _id of the record matches authid 5 - Search authorities in the staff client for "Computer prorgram" using Zebra Note that you can find authid 1707 in the results and view it 6 - Switch search engine to ES and repeat Note that you have a result that links to authid=potato and it doesn't work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103376&action=edit Bug 25229: Return authid of record rather than 001 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |joy@bywatersolutions.com, | |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- As far as I can tell, we do this for zebra in the background. Follow the recreation instructions and see that we index the authid as 001 even if the record is different, which is kinda crazy. We should at least be consistent. I have not included tests because we don't really yet have a way to fake ES for tests - we need bug 19821 as there are issues where records created for testing are indexed into ES if search engine config is set, but they don't get removed (for zebra they enter zebraqueue transactionally and are not committed) Everywhere this code is sued expects the correct authid afacit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103376|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 103738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103738&action=edit Bug 25229: Return authid of record rather than 001 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Document _id field, in authorities ES index, is always authid -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103759&action=edit Bug 25229: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103738|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103760&action=edit Bug 25229: Return authid of record rather than 001 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Document _id field, in authorities ES index, is always authid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 103761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103761&action=edit Bug 25229: (follow-up) Move QueryBuilder test to Elasticsearch dir -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103759|0 |1 is obsolete| | Attachment #103760|0 |1 is obsolete| | Attachment #103761|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103779&action=edit Bug 25229: Unit test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103780&action=edit Bug 25229: Return authid of record rather than 001 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Document _id field, in authorities ES index, is always authid Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103781&action=edit Bug 25229: (follow-up) Move QueryBuilder test to Elasticsearch dir Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|MARC Authority data support |Searching - Elasticsearch QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25229 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org