[Bug 37763] New: SQL reports Update and run SQL appends the editor screen after the report results.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Bug ID: 37763 Summary: SQL reports Update and run SQL appends the editor screen after the report results. Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: cj.lynce@westlakelibrary.org QA Contact: testopia@bugs.koha-community.org When editing SQL reports, using 'Update and run SQL' inappropriately includes the SQL editor at the bottom of the run report. Additionally, this issue causes the saved_sql.id to be appended repeated as described in bug_37307. Although there certainly could be some usefulness for SQL developers in having the editor appear under the report when testing, the SQL editing box does not function correctly (no auto population of tables, etc.). This is issues by the CSRF changes made in reports/guided_reports.pl that are causing to 'edit' screen to be appended to the 'run' screen. 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) See the report runs, but at the 'Edit SQL report' screen shows at the bottom (it should not) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 --- Comment #1 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 170839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170839&action=edit Bug 37763: SQL reports Update and run SQL inappropriately appends the editor screen after the ran report. This patch corrects an error where the SQL editor screen would appear after the report results when using 'Update and run SQL' when editing reports. This also corrects a related issue where the saved_sql.id of the report would be repeatedly appended to SQL code when using 'Update and run SQL'. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) See the report runs, but at the 'Edit SQL report' screen shows at the bottom. 6) Apply Patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) Verify that the report runs, but the 'Edit SQL report' section is gone. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37307 Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cj.lynce@westlakelibrary.or |ity.org |g -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam.sowanick@corvallisorego | |n.gov --- Comment #2 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- I tried Sign Off but the issue was not present on 24.06.00. I still have this issues on 24.05.02 (our test server). The Sandbox I was using doesn't allow to set specific versions (as far as I can tell). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 --- Comment #3 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Puzzling. I just re-verified the issue exists on the latest main in my KTD, as well as in ByWater's sandbox. In the event my steps are ambiguous, I have to first "Edit" a report (after creating), and use the "Update and run SQL" button for the behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170839|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 171039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171039&action=edit Bug 37763: SQL reports Update and run SQL inappropriately appends the editor screen after the ran report. This patch corrects an error where the SQL editor screen would appear after the report results when using 'Update and run SQL' when editing reports. This also corrects a related issue where the saved_sql.id of the report would be repeatedly appended to SQL code when using 'Update and run SQL'. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) See the report runs, but at the 'Edit SQL report' screen shows at the bottom. 6) Apply Patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) Verify that the report runs, but the 'Edit SQL report' section is gone. Sponsored-by: Westlake Porter Public Library Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- I found the error in my ways, thanks for the clarification. Signed off. Sam. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171039|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 171130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171130&action=edit Bug 37763: Do not show SQL report editor after 'Update and run' This patch corrects an error where the SQL editor screen would appear after the report results when using 'Update and run SQL' when editing reports. This also corrects a related issue where the saved_sql.id of the report would be repeatedly appended to SQL code when using 'Update and run SQL'. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) See the report runs, but at the 'Edit SQL report' screen shows at the bottom. 6) Apply Patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) Verify that the report runs, but the 'Edit SQL report' section is gone. Sponsored-by: Westlake Porter Public Library Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 171131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171131&action=edit Bug 37763 (QA follow-up): Tidy Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Added a tidy follow-up and reworded the first commit message so that it tells what the patch does instead of what the bug is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SQL reports Update and run |'Update and run SQL' |SQL appends the editor |appends the editor screen |screen after the report |after the report results |results. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up failed QA script for the commit message. Fixed before pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- *** Bug 37307 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- CUD not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37763 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ctodd@hcc.edu --- Comment #14 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 38245 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org