[Bug 28055] New: Convert DataTables option names to current version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Bug ID: 28055 Summary: Convert DataTables option names to current version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org We use a mixture of DataTables option names, some from 1.9.x and some from the current 1.10.x. For consistency's sake and to guard against possible future obsolescence I think we should convert our use to 1.10.x style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119004&action=edit Bug 28055: Convert DataTables option names to current version This patch makes changes the two global DataTables files in the staff interface, replacing older 1.9.x option names with the current 1.10.x version. To test, apply the patch and confirm that default DataTables behaviors continue to work correctly: Table information, "Show XX entries" controls, pagination, search. - Test tables which use the default DataTables configuration from datatables.js: - Administration -> Z39.50/SRU servers - Administration -> MARC frameworks -> MARC structure - Test tables which use the DataTables configuration in columns_settings.inc, including column visibility and export controls. - Administration -> Libraries - Patrons -> Patron search results - Circulation -> Holds queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 [Bug 28058] Move javascript out of columns_settings.inc into separate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119004|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119086&action=edit Bug 28055: Convert DataTables option names to current version This patch makes changes the two global DataTables files in the staff interface, replacing older 1.9.x option names with the current 1.10.x version. To test, apply the patch and confirm that default DataTables behaviors continue to work correctly: Table information, "Show XX entries" controls, pagination, search. - Test tables which use the default DataTables configuration from datatables.js: - Administration -> Z39.50/SRU servers - Administration -> MARC frameworks -> MARC structure - Test tables which use the DataTables configuration in columns_settings.inc, including column visibility and export controls. - Administration -> Libraries - Patrons -> Patron search results - Circulation -> Holds queue Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119086|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119161&action=edit Bug 28055: Convert DataTables option names to current version This patch makes changes the two global DataTables files in the staff interface, replacing older 1.9.x option names with the current 1.10.x version. To test, apply the patch and confirm that default DataTables behaviors continue to work correctly: Table information, "Show XX entries" controls, pagination, search. - Test tables which use the default DataTables configuration from datatables.js: - Administration -> Z39.50/SRU servers - Administration -> MARC frameworks -> MARC structure - Test tables which use the DataTables configuration in columns_settings.inc, including column visibility and export controls. - Administration -> Libraries - Patrons -> Patron search results - Circulation -> Holds queue Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119465&action=edit Bug 28055: (follow-up) Revert changes to aoColumnDefs option name This patch undoes changes to two lines in columns_settings.inc which were triggering unwanted side-effects. There are several templates and JavaScript files which use "aoColumnDefs" to pass options to columns settings, and if we change this file without changing those at the same time things will break. When these lines are updated it must be done so at the same time as we modify the templates which pass that same option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 [Bug 29193] DataTables only showing 20 results on checkout search and patrons search on request.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org