[Bug 26228] New: Update gulpfile to work with Node.js v12
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Bug ID: 26228 Summary: Update gulpfile to work with Node.js v12 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Node.js v8 has gone EOL on december 2019. We need to shift the required version to v12, but we rely on old gulp and friends that need to be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Severity|major |normal CC| |agustinmoyano@theke.io, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108402&action=edit Bug 26228: Update gulpfile to work with Node.js v12 This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12. On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'. Once that's done: 1. On your clone run: $ yarn install $ npm install -E 2. Build the CSS: $ yarn build $ yarn build --view opac => SUCCESS: Things build correctly 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm not on the Node.js camp but I rewrote the gulpfile.js following the Gulp v4 docs and it is pretty trivial. It works 'as it used to', so not a big deal IMHO. I removed the try/catch block that actually hides problems (if gulp cannot be loaded it will actually explode saying so, so...). TODO: gulp-util says it is deprecated and should be avoided. It's been like that for a while. They recommend minimist, but I didn't manage to make it work with our yarn build setup. Worth doing some short research on the subject. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108402|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108403&action=edit Bug 26228: Update gulpfile to work with Node.js v12 This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12. It also replaces the use of 'gulp-util' (deprecated) by 'minimist' as recommended on their site. On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'. Once that's done: 1. On your clone run: $ yarn install $ npm install -E 2. Build the CSS: $ yarn build $ yarn build --view opac => SUCCESS: Things build correctly 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #2)
TODO: gulp-util says it is deprecated and should be avoided. It's been like that for a while. They recommend minimist, but I didn't manage to make it work with our yarn build setup. Worth doing some short research on the subject.
^^ dealt with. We now use 'minimist'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- yarn build displays this warning: info fsevents@1.2.13: The platform "linux" is incompatible with this module. info "fsevents@1.2.13" is an optional dependency and failed compatibility check. Excluding it from installation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- yarn install, not yarn build -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108403|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108407&action=edit Bug 26228: Update gulpfile to work with Node.js v12 This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12. It also replaces the use of 'gulp-util' (deprecated) by 'minimist' as recommended on their site. On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'. Once that's done: 1. On your clone run: $ yarn install $ npm install -E 2. Build the CSS: $ yarn build $ yarn build --view opac => SUCCESS: Things build correctly 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108407|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108411&action=edit Bug 26228: Update gulpfile to work with Node.js v12 This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12. It also replaces the use of 'gulp-util' (deprecated) by 'minimist' as recommended on their site. On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'. Once that's done: 1. On your clone run: $ yarn install $ npm install -E 2. Build the CSS: $ yarn build $ yarn build --view opac => SUCCESS: Things build correctly 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 20.05.x for 20.05.04 (doing comment for Lucas) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.04 |20.11.00, 20.05.04, released in| |19.11.10 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
This patch makes the gulpfile work with gulp v4 on Node v12. To test it, make sure your dev env has Node.js v12.
On both KTD and KohaDevBox edit your sources.list so the node line points to 'node_12.x' instead of 'node_8.x'.
IIUC this means KTD needs also a patch to use node 12 to avoid having to do such a manual operation at every start of the environment. Is that correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Previous message ↑ in the context of backporting to 19.05.x but also to know if for the other branches, SCSS compilation is now more complicated than before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26228 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34376 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org