[Bug 27138] New: Host items are not included in Z39 results when using EasyAnalytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Bug ID: 27138 Summary: Host items are not included in Z39 results when using EasyAnalytics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If a library enables EasyAnalytics and links two records in the catalog then the host items show on the child record. If you search for these records via Z3950 (via zebra directly or the responder) the host items are not shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114126&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115158&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114126|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117333&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115158|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117334&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117333|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117346&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117334|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117347&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like this would classify more like an enhancement. The feature as is exists for many years now and while this is understandable request, I believe it's not a bug. The linking 773 entry is exported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
I feel like this would classify more like an enhancement. The feature as is exists for many years now and while this is understandable request, I believe it's not a bug.
I feel this is a bug, because the view in the catalog, and the view in Z39 are different, as well as the OPAC showing host item on details page and not the results page, but I can see the view of this as an enhancement.
The linking 773 entry is exported?
I don't understand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In Koha the host items shown on the child records is just a "view" feature, we store the data differently. The item is actually still only attached to one record. For me Z39.50 is more a "data" than a "view" thing, so I think that's where I was coming from. But of course I can see use cases for this too. If I understand correctly, you will have multiple records with completely the same items (including itemnumber, barcode etc.) after the patch. Depending on what you use Z39.50 for, I wonder if this could cause issues in other systems. I feel an urge to make this at least a configuration switch maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122035&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #9)
In Koha the host items shown on the child records is just a "view" feature, we store the data differently. The item is actually still only attached to one record. For me Z39.50 is more a "data" than a "view" thing, so I think that's where I was coming from.
But of course I can see use cases for this too.
If I understand correctly, you will have multiple records with completely the same items (including itemnumber, barcode etc.) after the patch. Depending on what you use Z39.50 for, I wonder if this could cause issues in other systems.
I feel an urge to make this at least a configuration switch maybe?
I added a syspref EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117346|0 |1 is obsolete| | Attachment #117347|0 |1 is obsolete| | Attachment #122035|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125698&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125699&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125700&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125701&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|tomascohen@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + require C4::Items; Why? There is a use in the module already. Formally, we should add 'use Koha::Items' though.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125698|0 |1 is obsolete| | Attachment #125699|0 |1 is obsolete| | Attachment #125700|0 |1 is obsolete| | Attachment #125701|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128175&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128176&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128177&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128178&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128179&action=edit Bug 27138: (follow-up) Remove extraneous require and use Koha::Items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but these no longer apply, could you please rebase? Bug 27138 - Host items are not included in Z39 results when using EasyAnalytics 128175 - Bug 27138: Index host items in child records when sending to search engine 128176 - Bug 27138: (follow-up) Embed host items when performing index from command line 128177 - Bug 27138: Add preference EmbedHostItemsInSearchEngine 128178 - Bug 27138: Import needed subroutines 128179 - Bug 27138: (follow-up) Remove extraneous require and use Koha::Items Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27138: Index host items in child records when sending to search engine Applying: Bug 27138: (follow-up) Embed host items when performing index from command line Using index info to reconstruct a base tree... M Koha/BiblioUtils.pm Falling back to patching base and 3-way merge... Auto-merging Koha/BiblioUtils.pm Applying: Bug 27138: Add preference EmbedHostItemsInSearchEngine error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27138: Add preference EmbedHostItemsInSearchEngine hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27138-Add-preference-EmbedHostItemsInSearchEng-GFwjoV.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128175|0 |1 is obsolete| | Attachment #128176|0 |1 is obsolete| | Attachment #128177|0 |1 is obsolete| | Attachment #128178|0 |1 is obsolete| | Attachment #128179|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139401&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139402&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139403&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139404&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139401|0 |1 is obsolete| | Attachment #139402|0 |1 is obsolete| | Attachment #139403|0 |1 is obsolete| | Attachment #139404|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144200&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144201&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144202&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144203&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> ---
13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC
With these patches applied, zebra search by barcode returns only the host on staff and OPAC. On the OPAC, search results when searching for the child record don't include the host item. I did a reset_all after applying patches. Was there something else I should have done to make the changes apply? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144200|0 |1 is obsolete| | --- Comment #32 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184746&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144201|0 |1 is obsolete| | --- Comment #33 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184747&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144202|0 |1 is obsolete| | --- Comment #34 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184748&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144203|0 |1 is obsolete| | --- Comment #35 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 184749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184749&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #36 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #31)
13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC
With these patches applied, zebra search by barcode returns only the host on staff and OPAC. On the OPAC, search results when searching for the child record don't include the host item.
I did a reset_all after applying patches. Was there something else I should have done to make the changes apply?
After a reset all you need to enable 'EmbedHostItemsInSearchEngine' and then rebuild both ES and Zebra: perl misc/search_tools/rebuild_elasticsearch.pl -v sudo koha-rebuild-zebra -v -f kohadev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch no longer applies, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27138: Index host items in child records when sending to search engine Applying: Bug 27138: (follow-up) Embed host items when performing index from command line Applying: Bug 27138: Add preference EmbedHostItemsInSearchEngine error: sha1 information is lacking or useless (C4/XSLT.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Host items are not included |Host items are not included |in Z39 results when using |in Z39.50 results when |EasyAnalytics |using EasyAnalytics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184746|0 |1 is obsolete| | Attachment #184747|0 |1 is obsolete| | Attachment #184748|0 |1 is obsolete| | Attachment #184749|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #38 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203871&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #39 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203872&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Michael Sutherland <sudrland@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #40 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203873&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #41 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203874&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #42 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203875&action=edit Bug 27138: (QA follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #43 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203876&action=edit Bug 27138: (QA follow-up) Add DB update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #44 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203877&action=edit Bug 27138: (QA follow-up) Remove tests on removed subroutine EmbedItemsInMarcBiblio -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org