[Bug 20986] New: MARC21 Supplement and Index Textual Holdings don't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Bug ID: 20986 Summary: MARC21 Supplement and Index Textual Holdings don't display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: joy@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha currently only displays the 866 Textual Holdings tag. It does not display the 867 Supplements or 868 Indexes Textual Holdings data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #1 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 76316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76316&action=edit Bug 20986 Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #2 from Joy Nelson <joy@bywatersolutions.com> --- Test plan * Create a big with multiple 866, 867 and 868 tags * Note that the display in OPAC and Staff Details pages does not contain 867, 868 textual holdings and the 866 tags are run together on one line * Apply the patch * Now the 867 and 868 tags display * Additionally the 866,867 and 868 are displayed one per line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |joy@bywatersolutions.com |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76316|0 |1 is obsolete| | --- Comment #3 from Ed Veal <eveal@mckinneytexas.org> --- Created attachment 78861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78861&action=edit Bug 20986 Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org --- Comment #4 from Ed Veal <eveal@mckinneytexas.org> --- This works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79550&action=edit Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79551&action=edit Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joy and Ed, I feel the line breaks would break the layout for some people - I know it would not work well with our data. I am proposing a slight change that is more in line with the current layout but will still allow you to have what you wanted with one line of CSS. Could you take a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79550|0 |1 is obsolete| | Attachment #79551|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88095&action=edit Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88096&action=edit Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88095|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89605&action=edit Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88096|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89606&action=edit Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #15 from Liz Rea <wizzyrea@gmail.com> --- I don't feel like maybe this was a thing that should have been in stable releases - it changes the front end OPAC and that's shocking for users. I don't think we need to take it out, but do be careful of these ones in the future please? Liz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org