[Bug 29364] New: Search.t not reverting changes made to the framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Bug ID: 29364 Summary: Search.t not reverting changes made to the framework Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org The tests are playing with the visibility (mss.hidden) of subfields, but does not revert it later. It leads to problem for other tests relying on default data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Found using the diag from commit c70de8c5305700cce9a6fe9a6f75c2cf53be02f1 Bug 28445: Add diag for failing test Temporary patch to help trying to fix the following random error: # Failed test 'Item types should be sorted by description and an empty entries should be shown' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 121. # Structures begin differing at: # $got->[12] = 'Be9T9FH5aO' # $expected->[12] = 'REF' # Looks like you failed 1 test of 2. # Failed test 'itemtypes' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 130. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- # Failed test 'Item types should be sorted by description and an empty entries should be shown' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 127. # Structures begin differing at: # $got = undef # $expected = ARRAY(0x557716b68e98) # Itemtypes details: $VAR1 = undef; # $VAR2 = [ # 'BK', # 'CF', # 'CR', # 'ihxGmo7', # 'MP', # 'MU', # 'MX', # 'REF', # 'VM' # ]; # Failed test 'Labels should be correctly displayed' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 130. # Structures begin differing at: # $got = undef # $expected = HASH(0x557716e2e150) # Looks like you failed 2 tests of 2. # Failed test 'itemtypes' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 133. subfield was hidden and so $subfield->{marc_value}->{values} was empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127080&action=edit Bug 29364: Revert changes to framework visibility made by Search.t To recreate run: drop database koha_kohadev; create database koha_kohadev; restart_all KOHA_TESTING=1 prove t/db_dependent/selenium/01-installation.t t/db_dependent/Search.t t/db_dependent/Koha/UI/Form/Builder/Item.t # Failed test 'Item types should be sorted by description and an empty entries should be shown' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 127. # Structures begin differing at: # $got = undef # $expected = ARRAY(0x557716b68e98) # Itemtypes details: $VAR1 = undef; # $VAR2 = [ # 'BK', # 'CF', # 'CR', # 'ihxGmo7', # 'MP', # 'MU', # 'MX', # 'REF', # 'VM' # ]; # Failed test 'Labels should be correctly displayed' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 130. # Structures begin differing at: # $got = undef # $expected = HASH(0x557716e2e150) # Looks like you failed 2 tests of 2. # Failed test 'itemtypes' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 133. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org