[Bug 21080] New: patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Bug ID: 21080 Summary: patron attribute classes break patron's edit view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 7154 When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154 [Bug 7154] Group borrower attributes and link between patron category and attribute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hum, maybe it comes from local changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- CC| |liz@catalyst.net.nz --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- I've seen this too, just now. Not sure what local change could have done it tbh. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Did you solve it, Jonathan? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- I think bug 20828 broke this - the attributes fall back in line when the homebound feature is enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20828 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I confirm it still exists indeed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #0)
To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron
4. Turn HouseboundModule on -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #0)
To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron
4. Turn HouseboundModule off (!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ha, it does not happen 100% of the time, it depends on the order of the fieldset and the ol elements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81598&action=edit Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81598|0 |1 is obsolete| | --- Comment #10 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81617&action=edit Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81617|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81645&action=edit Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Took a little bit of playing, but see the error and confirm it's fixed! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org