[Bug 33402] New: ERM Cypress tests needs to be moved to their own directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Bug ID: 33402 Summary: ERM Cypress tests needs to be moved to their own directory Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33370 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 [Bug 33370] Cypress tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149125&action=edit Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 [Bug 33408] Fetch sysprefs from svc/config/systempreferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Bug 33402 depends on bug 33370, which changed state. Bug 33370 Summary: Cypress tests are failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149125|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149192&action=edit Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149192|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 149336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149336&action=edit Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works[1], makes sense, QA script happy, code looks good, passing QA :) [1] with and without the patch, I got the same consistent failures of Licenses_spec.ts and random failures in other files. btw, is the CI running them? I couldn't find cypress output in the last builds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #4)
btw, is the CI running them
They are run at the end if no other failure happened. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149336|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149534&action=edit Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doh.. my bad.. I missed that Victor had already QA'd.. All good.. it's been pushed too now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's missing a test file that has been created in the meanwhile. git mv t/cypress/integration/Searchbar_spec.ts t/cypress/integration/ERM/Searchbar_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 149553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149553&action=edit Bug 33402: (follow-up) Move Searchbar_spec.ts Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 | released in| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #5)
(In reply to Victor Grousset/tuxayo from comment #4)
btw, is the CI running them
They are run at the end if no other failure happened.
ok! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Not backporting as additional_work_needed flag is active and this is dependent on 33408 which has not been backported Not changing status to RESOLVED FIXED - is the additional_work_needed flag still required now that Searchbar_spec.ts has been migrated? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The dependency is the other way around.. 33408 depends upon this. I think the additional_work_needed is a red herring too at this point.. I'm sure Tomas has pushed the follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)| |22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #14 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org