[Bug 17864] New: Increase coverage on admin pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Bug ID: 17864 Summary: Increase coverage on admin pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com Bug 17793 corrects tabs visible in the search area. These tests will check those. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58655&action=edit Test Cases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58655|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 58655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58655 Test Cases Wrong patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58656&action=edit Test Cases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |17793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 [Bug 17793] Make sysprefs search show on all Administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- I think that should also test: searchengine/elasticsearch/mappings.pl clone-rules.pl (see comment 12 on bug 17793) preferences.pl systempreferences.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58685&action=edit Bug 17864: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58686&action=edit Bug 17864: Follow up to add missing tests This adds tests for the missing items. Remember the kohadevbox has annoying caching issues, so close tab, vagrant halt, vagrant up just to be certain you are not failing because of caching. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Bug 17864 depends on bug 17793, which changed state. Bug 17793 Summary: Make sysprefs search show on all Administration pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Looks like I forgot to change the status back to needs sign off. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- P.S. This fails if plug ins are not enabled, as one of the tested pages is plugins. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Increase coverage on admin |Increase test coverage on |pages |admin pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58685|0 |1 is obsolete| | --- Comment #9 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64435&action=edit Bug 17864: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> https://bugs.koha-community.org/show_bug.cgi?id=17864 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Updated commit subject to reflect correct bug number. Works as directed according to test plan and passes QA tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58686|0 |1 is obsolete| | --- Comment #10 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64436&action=edit Bug 17864: Follow up to add missing tests This adds tests for the missing items. Remember the kohadevbox has annoying caching issues, so close tab, vagrant halt, vagrant up just to be certain you are not failing because of caching. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure to understand how useful these regression tests can be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64435|0 |1 is obsolete| | Attachment #64436|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66748&action=edit Bug 17793: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> https://bugs.koha-community.org/show_bug.cgi?id=17864 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66749&action=edit Bug 17864: Follow up to add missing tests This adds tests for the missing items. Remember the kohadevbox has annoying caching issues, so close tab, vagrant halt, vagrant up just to be certain you are not failing because of caching. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #11)
I am not sure to understand how useful these regression tests can be.
Answer still needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org