[Bug 8370] New: Default checkout, hold and return policy for all library => wrong term
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Priority: P2 Change sponsored?: --- Bug ID: 8370 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com, nengard@gmail.com Assignee: koha-bugs@lists.koha-community.org Blocks: 8362 Summary: Default checkout, hold and return policy for all library => wrong term Severity: normal Classification: Unclassified OS: All Reporter: paul.poulain@biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha The string "Default checkout, hold and return policy for all library" that appear in issuingrules when you're on "All" library is wrong. It's related to the rule that is applied by default if there is no library-level rule. Same problem with "Checkout limit by patron category for all libraries" and "Holds policy by itemtype for all libraries" => they refer to the behaviour if no library-level rule is set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nengard@gmail.com |ity.org | --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> --- Nicole, if you can do something with this bug and suggest a correct term (hoping you'll understand my description !) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- I think for "Default checkout, hold and return policy for all library" we can just remove the "for all libraries" part ... default to me implies a fall back. And then maybe change "Checkout limit by patron category for all libraries" to be "Default checkout limit by patron category" But I would think we might want to add something at the top of the ALL LIBRARIES rules to explain that if you only set those then they are applied to 'all libraries' but if you set specifics those are used instead - or something to make it clearer. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- That sounds like a good plan to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Jonathan, if you could make a patch for fixing those term issues, that would be perfect ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12274&action=edit Bug 8370: Change term issues (smart-rules) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- I also change the "Holds policy by item type" part for more consistency. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #7 from Marc Véron <veron@veron.ch> --- As Nicole pointed out in comment #2 the insturctions at the top of the page should be changed as well. Now the points regarding the defaults read as follows: all libraries, same patron type, same item type all libraries, same patron type, all item types all libraries, all patron types, same item type all libraries, all patron types, all item types It would be better to have e.g. default (all libraries), same patron type, same item type default (all libraries), same patron type, all item types default (all libraries), all patron types, same item type default (all libraries), all patron types, all item types Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12274|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12297&action=edit Bug 8370: Change term issues (smart-rules) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12297|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12304&action=edit Bug 8370: Change term issues (smart-rules) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #9)
Created attachment 12304 [details] Bug 8370: Change term issues (smart-rules)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
passing QA, patch looks good $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0a35b26) * 683bfd5 Bug 8370: Change term issues (smart-rules) koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt * koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master Follow-up suggestion: the page also says: For this library, you can specify the maximum number of loans that a patron of a given category can make, regardless of the item type. and For this library, you can edit rules for given itemtypes, regardless of the patron's category. Shouldn't we remove the "For this library" when you're on "All libraries" ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_8 |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org