[Bug 14842] New: Wrong call to GetBranchItemRule in circ/returns.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Bug ID: 14842 Summary: Wrong call to GetBranchItemRule in circ/returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 7981
From bug 7981:
circ/returns.pl around l. 276 my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype)->{'returnbranch'} || "homebranch"; GetBranchItemRule expects an itemtype, a scalar. Here $itemtype is a hashref returned by C4::ItemType->get. This must be blocker for the next release. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 [Bug 7981] Remove HomeOrHoldingBranchReturn syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42637&action=edit Bug 14842: Wrong call to GetBranchItemRule
From bug 7981:
GetBranchItemRule expects an itemtype, a scalar. Here $itemtype is a hashref returned by C4::ItemType->get. So $itemtype->{itemtype} should be passed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42637|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42803&action=edit Bug 14842: Wrong call to GetBranchItemRule
From bug 7981:
GetBranchItemRule expects an itemtype, a scalar. Here $itemtype is a hashref returned by C4::ItemType->get. So $itemtype->{itemtype} should be passed. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan or Marcel - can you please add a test plan to this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If I remember correctly you must use an itemtype with a return policy. Whatever the value of the policy, the return branch will always be the homebranch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42803|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43035&action=edit [PASSED QA] Bug 14842: Wrong call to GetBranchItemRule
From bug 7981:
GetBranchItemRule expects an itemtype, a scalar. Here $itemtype is a hashref returned by C4::ItemType->get. So $itemtype->{itemtype} should be passed. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org