[Bug 12456] New: The file C4/Maintainance.pm can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Bug ID: 12456 Summary: The file C4/Maintainance.pm can be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: yohann.dufour@biblibre.com QA Contact: testopia@bugs.koha-community.org With the command : git grep C4::Maintainance , we can see that the module is used nowhere. So, the files C4/Maintainance.pm, and by extension t/Maintainance.t, are useless, they can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |yohann.dufour@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 --- Comment #1 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 29087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29087&action=edit Bug 12456: The file C4/Maintainance.pm, and by extension the file t/Maintainance.t, has been removed The file C4/Maintainance.pm is not used anywhere, it can be removed, and by extension, the file t/Maintainance.t too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29087|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29126&action=edit [SIGNED-OFF] Bug 12456: The file C4/Maintainance.pm, and by extension the file t/Maintainance.t, has been removed The file C4/Maintainance.pm is not used anywhere, it can be removed, and by extension, the file t/Maintainance.t too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> A relic from the past :) No references to this file or it's subs No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But a functionality that would be nice to have again... being able to undo deletes of items and bilbios... :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29129&action=edit [PASSED QA] Bug 12456: The file C4/Maintainance.pm, and by extension the file t/Maintainance.t, has been removed The file C4/Maintainance.pm is not used anywhere, it can be removed, and by extension, the file t/Maintainance.t too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> A relic from the past :) No references to this file or it's subs No errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29126|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org