https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 155838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155838&action=edit Bug 34820: Clarify inventory tool message for items with non-matching notforloan value In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity. Test plan: 1) Create two items, one of which has the NFL status of "Ordered", the other having no NFL status 2) Enter those two barcodes in the inventory tool barcodes list 3) Check only "Ordered" in items.notforloan 4) Note the problem messages 5) Apply this patch 6) Re-run the inventory tool 7) Note the new clarified messages! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155838|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 155848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155848&action=edit Bug 34820: Clarify inventory tool message for items with non-matching notforloan value In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity. Test plan: 1) Create two items, one of which has the NFL status of "Ordered", the other having no NFL status 2) Enter those two barcodes in the inventory tool barcodes list 3) Check only "Ordered" in items.notforloan 4) Note the problem messages 5) Apply this patch 6) Re-run the inventory tool 7) Note the new clarified messages! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155848|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 155849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155849&action=edit Bug 34820: Clarify inventory tool message for items with non-matching notforloan value In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity. Test plan: 1) Create two items, one of which has the NFL status of "Ordered", the other having no NFL status 2) Enter those two barcodes in the inventory tool barcodes list 3) Check only "Ordered" in items.notforloan 4) Note the problem messages 5) Apply this patch 6) Re-run the inventory tool 7) Note the new clarified messages! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155849|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 155871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155871&action=edit Bug 34820: Clarify inventory tool message for items with non-matching notforloan value In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity. Test plan: 1) Create two items, one of which has the NFL status of "Ordered", the other having no NFL status 2) Enter those two barcodes in the inventory tool barcodes list 3) Check only "Ordered" in items.notforloan 4) Note the problem messages 5) Apply this patch 6) Re-run the inventory tool 7) Note the new clarified messages! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Text to go in the|This fixes the inventory |This fixes the inventory release notes|tool to clarify the message |tool to clarify the message |for items with non-matching |for items with non-matching |notforloan values in the |not for loan values in the |inventory results |inventory results |'Problems' column. |'Problems' column. | | |It: |It: |- |- |Adds a hint on the |Adds a hint on the |inventory tool page under |inventory tool page under |'Optional filters for |'Optional filters for |inventory list or comparing |inventory list or comparing |barcodes' section. |barcodes' section. |- |- |Clarifies the message in |Clarifies the message in |the 'Problems' column: from |the 'Problems' column: from |'Unknown not-for-loan |'Unknown not-for-loan |status' to 'Items has no |status' to 'Items has no |not for loan status'. |not for loan status'. | | |(If |(If |one or more not for loan |one or more not for loan |values (Optional filters |values (Optional filters |for inventory list or |for inventory list or |comparing barcodes > |comparing barcodes > |items.notforloan) are |items.notforloan) are |selected, and an item is |selected, and an item is |scanned that has no NFL |scanned that has no NFL |status or an unselected NFL |status or an unselected NFL |status, the error message |status, the error message |was "Unknown not-for-loan |was "Unknown not-for-loan |status". This could be |status". This could be |interpreted as the item |interpreted as the item |having an NFL status value |having an NFL status value |that is not defined in the |that is not defined in the |system, but that is not |system, but that is not |accurate. This is now |accurate. This is now |clarified and the error |clarified and the error |message is now "Items has |message is now "Items has |no not for loan status". |no not for loan status". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: do we need a fix to the code for exporting to CSV as well? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155871|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 155928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155928&action=edit Bug 34820: (QA follow-up) add filter, update CSV output -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's not the wording, it's the formatting. I'd forgo the <em> for quotes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 155957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155957&action=edit Bug 34820: (QA follow-up) Replace em tags with quotes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #9)

It's not the wording, it's the formatting. I'd forgo the <em> for quotes.

Katrin, can you have another look as this now that I've replaced them em tags? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the inventory |This fixes the inventory release notes|tool to clarify the message |tool to clarify the message |for items with non-matching |for items with non-matching |not for loan values in the |not for loan values in the |inventory results |inventory results |'Problems' column. |'Problems' column. | | |It: |It: |- |- |Adds a hint on the |Adds a hint on the |inventory tool page under |inventory tool page under |'Optional filters for |'Optional filters for |inventory list or comparing |inventory list or comparing |barcodes' section. |barcodes' section. |- |- |Clarifies the message in |Clarifies the message in |the 'Problems' column: from |the 'Problems' column: from |'Unknown not-for-loan |'Unknown not-for-loan |status' to 'Items has no |status' to 'Items has no |not for loan status'. |not for loan status'. | | |(If |If |one or more not for loan |one or more not for loan |values (Optional filters |values (Optional filters |for inventory list or |for inventory list or |comparing barcodes > |comparing barcodes > |items.notforloan) are |items.notforloan) are |selected, and an item is |selected, and an item is |scanned that has no NFL |scanned that has no NFL |status or an unselected NFL |status or an unselected NFL |status, the error message |status, the error message |was "Unknown not-for-loan |was "Unknown not-for-loan |status". This could be |status". This could be |interpreted as the item |interpreted as the item |having an NFL status value |having an NFL status value |that is not defined in the |that is not defined in the |system, but that is not |system, but that is not |accurate. This is now |accurate. This is now |clarified and the error |clarified and the error |message is now "Items has |message is now "Items has |no not for loan status". |no not for loan status". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155871|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156499&action=edit Bug 34820: Clarify inventory tool message for items with non-matching notforloan value In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity. Test plan: 1) Create two items, one of which has the NFL status of "Ordered", the other having no NFL status 2) Enter those two barcodes in the inventory tool barcodes list 3) Check only "Ordered" in items.notforloan 4) Note the problem messages 5) Apply this patch 6) Re-run the inventory tool 7) Note the new clarified messages! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155957|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156501&action=edit Bug 34820: (QA follow-up) Replace em tags with quotes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arg we try to avoid double quotes in translated strings, because of JavaScript. This string may not end in a JavaScript code but better be safe. Can it be " or single quotes ? I see we use " is some places : https://git.koha-community.org/Koha-community/Koha/src/commit/af093305b8c936... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement Summary|Clarify inventory tool |Improve inventory tool |message for items with |message for items with |non-matching notforloan |non-matching notforloan |value |values CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.