[Bug 12357] New: Enhancements to RIS and BibTeX exporting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Bug ID: 12357 Summary: Enhancements to RIS and BibTeX exporting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28646&action=edit Bug 12357 [1] - Add ability to export arbitrary fields for RIS format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the LC and multiple NT fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28647&action=edit Bug 12357 [2] - Add ability to use record level itemtype for RIS export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference RisUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as RIS 6) View the record, note the TY field is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28648&action=edit Bug 12357 [3]- Add ability to export arbitrary fields for BibTex format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref BibtexExportAdditionalFields: lccn: 010$a notes: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select BIBTEX 6) Inspect the downloaded file, note the lccn and multiple note fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28649&action=edit Bug 12357 [4] - Add ability to use record level itemtype for BibTeX export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference BibUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as BIBTEX 6) View the record, note that instead of @BOOK, the type is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28649|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28650&action=edit Bug 12357 [4] - Add ability to use record level itemtype for BibTeX export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference BibUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as BIBTEX 6) View the record, note that instead of @BOOK, the type is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Just thought I'd ask how this might interact with Bug 11592. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28646|0 |1 is obsolete| | Attachment #28647|0 |1 is obsolete| | Attachment #28648|0 |1 is obsolete| | Attachment #28650|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29291&action=edit Bug 12357 [1] - Add ability to export arbitrary fields for RIS format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the LC and multiple NT fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29292&action=edit Bug 12357 [2] - Add ability to use record level itemtype for RIS export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference RisUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as RIS 6) View the record, note the TY field is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29293&action=edit Bug 12357 [3]- Add ability to export arbitrary fields for BibTex format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref BibtexExportAdditionalFields: lccn: 010$a notes: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select BIBTEX 6) Inspect the downloaded file, note the lccn and multiple note fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29294&action=edit Bug 12357 [4] - Add ability to use record level itemtype for BibTeX export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference BibUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as BIBTEX 6) View the record, note that instead of @BOOK, the type is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29292|0 |1 is obsolete| | Attachment #29293|0 |1 is obsolete| | Attachment #29294|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29295&action=edit Bug 12357 [2] - Add ability to use record level itemtype for RIS export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference RisUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as RIS 6) View the record, note the TY field is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29296&action=edit Bug 12357 [3]- Add ability to export arbitrary fields for BibTex format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref BibtexExportAdditionalFields: lccn: 010$a notes: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select BIBTEX 6) Inspect the downloaded file, note the lccn and multiple note fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29297&action=edit Bug 12357 [4] - Add ability to use record level itemtype for BibTeX export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference BibUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as BIBTEX 6) View the record, note that instead of @BOOK, the type is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29291|0 |1 is obsolete| | Attachment #29295|0 |1 is obsolete| | Attachment #29296|0 |1 is obsolete| | Attachment #29297|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31677&action=edit Bug 12357 [1] - Add ability to export arbitrary fields for RIS format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the LC and multiple NT fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31678&action=edit Bug 12357 [2] - Add ability to use record level itemtype for RIS export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference RisUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as RIS 6) View the record, note the TY field is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31679&action=edit Bug 12357 [3]- Add ability to export arbitrary fields for BibTex format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref BibtexExportAdditionalFields: lccn: 010$a notes: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select BIBTEX 6) Inspect the downloaded file, note the lccn and multiple note fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31680&action=edit Bug 12357 [4] - Add ability to use record level itemtype for BibTeX export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference BibUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as BIBTEX 6) View the record, note that instead of @BOOK, the type is your record's itemtype code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31677|0 |1 is obsolete| | --- Comment #18 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33123&action=edit Bug 12357 [1] - Add ability to export arbitrary fields for RIS format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the LC and multiple NT fields Signed-off-by: Frederic Demians <f.demians@tamil.fr> Tested with unimarc db. Populating RisExportAdditionalFields, RIS exported records can contain new RIS specific fields populated by field/subfield. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31678|0 |1 is obsolete| | --- Comment #19 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33124&action=edit Bug 12357 [2] - Add ability to use record level itemtype for RIS export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference RisUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as RIS 6) View the record, note the TY field is your record's itemtype code Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm that with this patch TY RIS field can contain biblioitems.itemtype field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31679|0 |1 is obsolete| | --- Comment #20 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33125&action=edit Bug 12357 [3]- Add ability to export arbitrary fields for BibTex format Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref BibtexExportAdditionalFields: lccn: 010$a notes: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select BIBTEX 6) Inspect the downloaded file, note the lccn and multiple note fields Signed-off-by: Frederic Demians <f.demians@tamil.fr> Similar to RIS patch [1]. Functionnal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31680|0 |1 is obsolete| | --- Comment #21 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33126&action=edit Bug 12357 [4] - Add ability to use record level itemtype for BibTeX export type Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preference BibUseItemtypeAsType 4) Choose a record that has a set biblio level itemtype 5) Save this record as BIBTEX 6) View the record, note that instead of @BOOK, the type is your record's itemtype code Signed-off-by: Frederic Demians <f.demians@tamil.fr> Similar to RIS [2] patch. Functionnal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have a few concerns about this feature: I think we have several features here on one bug report, so it's a bit hard to work through. I really like the idea of the arbitrary fields, but I am concerned about using the record level itemtype. This seems to assume that different itemtypes are used for different type of media. I am not sure this is how all libraries use itemtypes in Koha, some differentiate by loan types. But this is just a note, my main concern is about the missing flexibility for existing installations. If you are a long term user of Koha you would probably have to change all your itemtype codes in order to be able to make good use of the new feature. This feels quite problematic to me. I am not sure what's the best way to resolve this, some thoughts I had while reading through it: Instead of using a separate system preference, maybe allowing overwriting existing fields would be an option? Then you could use *ExportAdditionalFields with 942$c for the itemtype feature or even use another arbitrary field the library thinks is best suited. Or a little easier: allow defining the MARC subfield to use for the record type instead of hardcoding it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> ---
Instead of using a separate system preference, maybe allowing overwriting existing fields would be an option? Then you could use *ExportAdditionalFields with 942$c for the itemtype feature or even use another arbitrary field the library thinks is best suited.
That is a capital idea! I will be implementing this shortly! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33123|0 |1 is obsolete| | Attachment #33124|0 |1 is obsolete| | Attachment #33125|0 |1 is obsolete| | Attachment #33126|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35485&action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35487&action=edit Bug 12357 - Tidy Ris.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35489&action=edit Bug 12357 - Tidy Record.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, How did you tidy Ris.pm? It seems you did not used perltidy: $ perltidy C4/Ris.pm $ diff C4/Ris.pm C4/Ris.pm.tdy | wc 214 1064 10403 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #27)
Kyle, How did you tidy Ris.pm? It seems you did not used perltidy: $ perltidy C4/Ris.pm $ diff C4/Ris.pm C4/Ris.pm.tdy | wc 214 1064 10403
Yes, I did indeed use perltidy. I think this is a really good opportunity to tidy both of these modules. Only bug 12404 modifies Record.pm in any serious way, and that will be pushed to master before this one ( and I'll have to submit a fresh followup ). Ris.pm has no other patches in process that touch it at all. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #28)
(In reply to Jonathan Druart from comment #27)
Kyle, How did you tidy Ris.pm? It seems you did not used perltidy: $ perltidy C4/Ris.pm $ diff C4/Ris.pm C4/Ris.pm.tdy | wc 214 1064 10403
Yes, I did indeed use perltidy.
Do you use a specific .perltidyrc file? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #29)
(In reply to Kyle M Hall from comment #28)
(In reply to Jonathan Druart from comment #27)
Kyle, How did you tidy Ris.pm? It seems you did not used perltidy: $ perltidy C4/Ris.pm $ diff C4/Ris.pm C4/Ris.pm.tdy | wc 214 1064 10403
Yes, I did indeed use perltidy.
Do you use a specific .perltidyrc file?
Here is the entiretly of my tidy rc file. I know it's deviating from the standard default, but we live in an age where monitors are a bit bigger than they used to be: -l=120 I can re-tidy the file with pure default Tidy ( the currently accepted Koha standard iirc ) if you wish. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35485|0 |1 is obsolete| | Attachment #35487|0 |1 is obsolete| | Attachment #35489|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35826&action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35827&action=edit Bug 12357 - Tidy Ris.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35828&action=edit Bug 12357 - Tidy Record.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, same with these patch. For instance: diff C4/Ris.pm C4/Ris.pm.tdy returns: < elsif ( $fieldname eq "534" ) { < @subfields = < ( 'a', 'b', 'c', 'e', 'f', 'k', 'l', 'm', 'n', 'p', 't', 'x', 'z' ); < } < elsif ( $fieldname eq "535" ) { ---
} elsif ( $fieldname eq "534" ) { @subfields = ( 'a', 'b', 'c', 'e', 'f', 'k', 'l', 'm', 'n', 'p', 't', 'x', 'z' ); } elsif ( $fieldname eq "535" ) {
and 898,901c811 < my @subfields = ( < 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'o', < 'p', 'q', 'r', 's', 't', 'u', 'v', 'x', 'y', 'z', '2', '3', '4' < ); ---
my @subfields = ( 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'x', 'y', 'z', '2', '3', '4' );
It's weird because I have 40 --maximum-line-length=178 in my ~/.perltidyrc But it does not seem to be take into account. If I launch it with perltidy C4/Ris.pm --noprofile I get the same file as you. I think I have spot a problem in the file: 275 '607', '608', '610', '615', '620', '660' . '661', should be 275 '607', '608', '610', '615', '620', '660' , '661', It existed before this patch. I won't block this patch, but maybe it could be good to have a specific bug report for tidying these files and talk about a common perltidyrc file to use. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Rolando Isidoro <rolando.isidoro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rolando.isidoro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, could you please provide tests, at least of the marc2bibtex subroutine. And I would prefer to see the tidy job (the 2 last patches) moved to another bug report. Moreover, the indentation changes in C4::Record::marcrecord2csv will be in conflict with bug 12404. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7989 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35826|0 |1 is obsolete| | Attachment #35827|0 |1 is obsolete| | Attachment #35828|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38602&action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38604&action=edit Bug 12357 [QA Followup] - Unit Test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, The test does not pass. # Failed test 'testing bibtex' # at /home/koha/src/t/db_dependent/Record.t line 123. # got: '@Scholastic{testID, # author = {Rowling, J.K.}, # title = {Harry potter}, # publisher = {Scholastic}, # year = {2001} # test = {Scholastic} # } # ' # expected: '@Scholastic{testID, # author = {Rowling, J.K.}, # title = {Harry potter}, # publisher = {Scholastic}, # year = {2001}, # test = {Scholastic} # } # ' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #39 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39469&action=edit Bug 12357: Fix comma issues related to additional fields. TEST PLAN --------- 1) Apply patches, except this one. 2) prove t/db_dependent/Record.t -- fails like comment #38 3) Apply this patch 4) prove t/db_dependent/Record.t -- now it passes. 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #40 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39471&action=edit Bug 12357 - Following whitespace failures on koha qa test tools. TEST PLAN --------- 1) Apply all patches before this. 2) run koha qa test tools -- whitespace failures 3) Apply this patch 4) run koha qa test tools -- no whitespace failures. NOTE: More tabs were fixed than required, to also clean up a little indenting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38602|0 |1 is obsolete| | --- Comment #41 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39773&action=edit [SIGNED_OFF] Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38604|0 |1 is obsolete| | --- Comment #42 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39774&action=edit [SIGNED_OFF] Bug 12357 [QA Followup] - Unit Test Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> This works with next patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39469|0 |1 is obsolete| | --- Comment #43 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39775&action=edit [SIGNED_OFF] Bug 12357: Fix comma issues related to additional fields. TEST PLAN --------- 1) Apply patches, except this one. 2) prove t/db_dependent/Record.t -- fails like comment #38 3) Apply this patch 4) prove t/db_dependent/Record.t -- now it passes. 5) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Make test work, koha-qa problems fixed in next patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39471|0 |1 is obsolete| | --- Comment #44 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39776&action=edit [SIGNED_OFF] Bug 12357 - Following whitespace failures on koha qa test tools. TEST PLAN --------- 1) Apply all patches before this. 2) run koha qa test tools -- whitespace failures 3) Apply this patch 4) run koha qa test tools -- no whitespace failures. NOTE: More tabs were fixed than required, to also clean up a little indenting. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Koha-qa tools now happy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39773|0 |1 is obsolete| | Attachment #39774|0 |1 is obsolete| | Attachment #39775|0 |1 is obsolete| | Attachment #39776|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39803&action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39804&action=edit Bug 12357 [QA Followup] - Unit Test Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> This works with next patch Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39805&action=edit Bug 12357: Fix comma issues related to additional fields. TEST PLAN --------- 1) Apply patches, except this one. 2) prove t/db_dependent/Record.t -- fails like comment #38 3) Apply this patch 4) prove t/db_dependent/Record.t -- now it passes. 5) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Make test work, koha-qa problems fixed in next patch Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39806&action=edit Bug 12357 - Following whitespace failures on koha qa test tools. TEST PLAN --------- 1) Apply all patches before this. 2) run koha qa test tools -- whitespace failures 3) Apply this patch 4) run koha qa test tools -- no whitespace failures. NOTE: More tabs were fixed than required, to also clean up a little indenting. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Koha-qa tools now happy Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #49 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note that now strict and warnings are enabled, the log contains a lot of 'Use of uninitialized value". But it's not introduced by this patch set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org