[Bug 20022] New: use Modern::Perl in t (test) perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Bug ID: 20022 Summary: use Modern::Perl in t (test) perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_annual.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t smolder_smoke_signal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Grace <gracesmythh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 --- Comment #1 from Grace <gracesmythh@gmail.com> --- Created attachment 70717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70717&action=edit Bug 20022 - use Modern::Perl in t (test) perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_annual.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t smolder_smoke_signal :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Appears to be missing 'use Modern::Perl;' in: t/Barcodes_annual.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70717|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 83857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83857&action=edit Bug 20022 - use Modern::Perl in t (test) perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jon Knight from comment #2)
Appears to be missing 'use Modern::Perl;' in:
t/Barcodes_annual.t
The reason this was skipped is because there is no use strict; use warnings; so we don't want to add them if they're not already being used. It was likely accidentally added to the commit message. Patch has been rebased and is ready to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleisha@catalyst.net.nz |koha-bugs@lists.koha-commun | |ity.org Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Abdivasiyev Sunnatillo <abdivasiyevsunnatillo2008@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abdivasiyevsunnatillo2008@g | |mail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org