[Bug 30190] New: Green buttons turn blue for a second when clicking them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Bug ID: 30190 Summary: Green buttons turn blue for a second when clicking them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When clicking green buttons, like the "Go" button in simple search, it turns dark blue for a second before returning to green. In testing bug 29616 we were not sure if this was intentional, so filing a bug to check and confirm.
From the comments:
(In reply to Lucas Gass from comment #9)
That appears to be from this rule in the OPAC CSS file:
.btn-primary:not(:disabled):not(.disabled).active, .btn-primary:not(:disabled):not(.disabled):active, .show > .btn-primary.dropdown-toggle { color: #fff; background-color: #0062cc; border-color: #005cbf; }
Do we file a new bug? It seems like perhaps it was intentional to have the blue.
(In reply to Fridolin Somers from comment #10)
(In reply to Lucas Gass from comment #9)
Do we file a new bug? It seems like perhaps it was intentional to have the blue.
Yep, please open another bug report. We will close invalid if it is on purpose.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131255&action=edit Bug 30190: Green buttons turn blue for a second when clicking them This patch adds additional CSS to better cover various states of buttons in the OPAC. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... - In the OPAC, test various green buttons in varous states: default, hover, and active (the appearance when the button is clicked but before the mouse button is released). - The button should be styled in various shades of green in all cases. - Test a disabled button by performing a catalog search. - On the results page, before any checkboxes are checked, the "Save" button should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131255|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131259&action=edit Bug 30190: Green buttons turn blue for a second when clicking them This patch adds additional CSS to better cover various states of buttons in the OPAC. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... - In the OPAC, test various green buttons in varous states: default, hover, and active (the appearance when the button is clicked but before the mouse button is released). - The button should be styled in various shades of green in all cases. - Test a disabled button by performing a catalog search. - On the results page, before any checkboxes are checked, the "Save" button should look correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Owen, that looks much better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131259|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131409&action=edit Bug 30190: Green buttons turn blue for a second when clicking them This patch adds additional CSS to better cover various states of buttons in the OPAC. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... - In the OPAC, test various green buttons in varous states: default, hover, and active (the appearance when the button is clicked but before the mouse button is released). - The button should be styled in various shades of green in all cases. - Test a disabled button by performing a catalog search. - On the results page, before any checkboxes are checked, the "Save" button should look correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org