[Bug 30770] New: Terminology: Lost reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Bug ID: 30770 Summary: Terminology: Lost reserve Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org reserve should be hold here: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt:135 Lost reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 --- Comment #1 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 137342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137342&action=edit Bug 30770: Fixed terminology 'reserve' -> 'hold' Test plan: 1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt 2. Note that it says 'Lost reserve' 3. Apply patch 4. Note that it says 'Lost hold' Sponsored by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Koha Training Catalyst <koha-training@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Koha Training Catalyst <koha-training@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137342|0 |1 is obsolete| | --- Comment #2 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 137343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137343&action=edit Bug 30770: Fixed terminology 'reserve' -> 'hold' Test plan: 1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt 2. Note that it says 'Lost reserve' 3. Apply patch 4. Note that it says 'Lost hold' Note: I was not able to trigger the behaviour to see the text in question Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137343|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 137347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137347&action=edit Bug 30770: Fixed terminology 'reserve' -> 'hold' Test plan: 1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt 2. Note that it says 'Lost reserve' 3. Apply patch 4. Note that it says 'Lost hold' Note: I was not able to trigger the behaviour to see the text in question Sponsored-by: Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Patch looks fine, needs independent signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30764 Version|unspecified |master Assignee|oleonard@myacpl.org |toscawaerea@catalyst.net.nz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764 [Bug 30764] Terminology: Cancelled reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137347|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137376&action=edit Bug 30770: Fixed terminology 'reserve' -> 'hold' Test plan: 1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt 2. Note that it says 'Lost reserve' 3. Apply patch 4. Note that it says 'Lost hold' Note: I was not able to trigger the behaviour to see the text in question Sponsored-by: Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for your patch, Tosca! Going straight to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137378&action=edit Bug 30770: (QA follow-up) Fixing the last occurrence of reserve in returns.tt Reserve -> Hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.04, released in| |21.11.11 --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- found in 22.05.x for 22.05.04. backporting in 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |Needs documenting --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The string 'lost reserve' is not in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770 Bug 30770 depends on bug 30764, which changed state. Bug 30764 Summary: Terminology: Cancelled reserve https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org