[Bug 7467] New: Printing Transfer Slips that do not have holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Bug #: 7467 Summary: Printing Transfer Slips that do not have holds Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com Work to be done: * Create circ/transfer-slip.pl and circ/transfer-slip.tt similar to hold-transfer-slip * circ/returns.tt: add "Yes and Print Slip" button that will call Dopop('transfer-slip.pl') * Remove inputloop and ri-* variables code from circ/returns, it is not used and is confusing How to test: * When returning an item without holds rhat needs to be transferred to home branch "Yes and Print Slip" button should show * Click athe button and print slip. Meaningful To and From branch, as well as item info should print -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff AssignedTo|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-25 06:04:14 UTC --- Created attachment 7329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7329 patch Did not remove ri-*, that seems to be used to display all checked in items when checking in one item after another -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2012-01-25 16:04:41 UTC --- srdjan - how does this relate to 7001? (if at all) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 --- Comment #3 from Liz Rea <wizzyrea@gmail.com> 2012-01-25 16:15:43 UTC --- observation - the Circulation -> transfer functionality could use this slip too, is that considered too much of a scope creep? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2012-01-25 17:07:58 UTC --- I got the patch applied just fine, but I don't seem to get the changes when I check in a book that needs to go home - it looks the same as it always does? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-27 01:04:51 UTC --- * how does this relate to 7001? It does not, this is an ad hoc slip. Of course, it could be turned into a templated TRANSF (or some other code) slip once 7001 is done * Circulation -> transfer functionality could use this slip too It can be done, but I would need to requote, it would meed some additional javascript to pick up selected destination branch * I don't seem to get the changes Can it be for some sysprefs reason? In general, if "Yes" transfer button is on the screen, "Yes and Print Slip" must be there too -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-06 17:57:19 UTC --- Attempted to test this patch. Path applies cleanly, but the "Yes and Print Slip" button never appears. What situation should cause this button to appear? I've tried to situations: 1) Check out item to patron at LibraryA, return at LibraryB, this results in the message "Please Return <Item Title> to LibraryA". 2) Item that has a holding and home branch of LibraryA, but not checked out to a borrower, is checked in to LibraryB, results in the same message as situation 1. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-07 01:49:47 UTC --- 1. When I do this scenario I get "This item needs to be transferred to <missing branch name, a bug>. Transfer Now?" and "Yes and Print Slip" button. I think it has something to do with your userenv library, but I cannot pinpoint what exactly. Can you please try maybe with two computers (or different browsers, explorer, firefox, chrome, opera) and log in as different users with different home branches. 2. When I do that, I get "Print slip, Transfer, and Confirm", which was already there (not part of this bug). This could be happening because your library is the holding destination ( similar userenv issue) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-20 14:43:52 UTC --- The button only appears if AutomaticItemReturn is turned off, I don't see a reason for only being able to print the slip if AutomaticItemReturn is disabled. Other than that, it works just fine. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-20 14:45:34 UTC --- Created attachment 7775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7775 bug_7467: Printing Transfer Slips for transfers that do not have holds Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7329|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-20 14:48:30 UTC --- Created attachment 7776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7776 bug_7467: Printing Transfer Slips for transfers that do not have holds - Addendum: Use for automatic transfers as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Blocks| |7001 Summary|Printing Transfer Slips |Printing Transfer Slips for |that do not have holds |checkin items that do not | |have holds but need | |transfer --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 14:09:45 UTC --- QA comment: * passes test * only a few lines on existing code * new scripts/template properly written * i've added a link to bug 7001 not to forget to introduce the slips in notifications passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7467 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org