[Bug 19326] New: Report editor in guided_reports.pl truncates reports longer than 64 KiB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326 Bug ID: 19326 Summary: Report editor in guided_reports.pl truncates reports longer than 64 KiB Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 67151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67151&action=edit A query longer than 65535; this will be truncated when saved. The field saved_sql.savedsql is type 'text', which is 65535 characters long. mysql> select table_name, column_name, data_type from information_schema.columns where column_name = 'savedsql'; +------------+-------------+-----------+ | table_name | column_name | data_type | +------------+-------------+-----------+ | saved_sql | savedsql | text | +------------+-------------+-----------+ The query editor in guided_reports.pl does not check the size of the report being saved, causing the report to be truncated if its more than 65535 characters long. I would suggest changing the data type of savedsql to LONGTEXT, then limiting the query length to something fairly large, but less than 4,294,967,295 characters, with a warning (to avoid denial of service by filling the hard drive). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- Set to MAJOR because of data loss. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you give an example of a report (that would be wise to run) that is that long? I think major is too much here, we probably have a lot of fields if not all that cut off data if too long. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326 --- Comment #3 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #2)
Can you give an example of a report (that would be wise to run) that is that long? I think major is too much here, we probably have a lot of fields if not all that cut off data if too long.
Cait, See the attached file. It poses no danger when run because it's syntactically incorrect when imported. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It just killed my editor... kind of makes me worry if it's wise to recommend it for use with Koha :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19326 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not opposed to make the field bigger, was just wondering. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org