[Bug 6489] New: cancelling hold from holds awaiting pickup does not trigger transit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Bug #: 6489 Summary: cancelling hold from holds awaiting pickup does not trigger transit Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Hold requests AssignedTo: ian.walls@bywatersolutions.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com When an expired hold is canceled using this report, the status of the item changes from "Waiting for Patron A" to "Available." The status does not indicate that a transfer has been triggered. Unlike before the recent upgrade, the current location changes to the owning branch rather than erroneously updating the the holding branch. Here is my testing. http://screencast.com/t/aekZRW6Hh -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-19 04:59:58 UTC --- I have tried this on the master branch and it is reporting "In transit from X, to Y, since dd/mm/yyyy Which version are you running please? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-09-29 14:47:23 UTC --- Srdjan, I will re-test this today on Master. I'm sure that this was on a version somewhat back from the bleeding edge of master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Sharon Moreland <smoreland@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smoreland@nekls.org --- Comment #3 from Sharon Moreland <smoreland@nekls.org> 2011-11-03 17:07:55 UTC --- This bug seems to be fixed. The transit home for re-shelving occurs and if another hold is found, the 'submit query' button appears. The process is clunky and could use improvement, such as transfer and "confirm hold, print slip and transfer" prompts. My testing: http://screencast.com/t/lneRY70yW -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 --- Comment #4 from Sharon Moreland <smoreland@nekls.org> 2011-11-03 17:13:05 UTC --- I took this one step further - I scanned in the barcode of an item put into transit to fill a hold using the Holds Awaiting Pick-up reports "submit query" button. You get 2 transfer prompts, but confirming the hold (the bottom prompt) acts as expected. Silent video: http://screencast.com/t/dKXmrULwM I suppose making this report provide the same dialogue boxes and such will need to be an enhancement request? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ian.walls@bywatersolutions. |srdjan@catalyst.net.nz |com | --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-12-02 04:06:27 UTC --- Created attachment 6504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6504 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Michael Hafen <mdhafen@tech.washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mdhafen@tech.washk12.org --- Comment #6 from Michael Hafen <mdhafen@tech.washk12.org> 2011-12-02 18:36:02 UTC --- I looked at this patch and it raises a question for me, which is how it interacts with the IndependantBranches setting. It will depend on how well CheckReserves handles IndependantBranches, which as I recall isn't good. Maybe that has changed in master though. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 07:36:07 UTC --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: bug_6489: Do not raise WrongTransfer if it is transrerring to reserve branch Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm Failed to merge in the changes. Patch failed at 0001 bug_6489: Do not raise WrongTransfer if it is transrerring to reserve branch When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6504|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-12-21 08:00:20 UTC --- Created attachment 6899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6899 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> 2011-12-21 20:03:25 UTC --- This new patch applies for me - will test. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 --- Comment #10 from Sharon Moreland <smoreland@nekls.org> 2012-01-04 18:03:01 UTC --- The Holds Awaiting Pickup report buttons now works - good news (see testing video below). However, behavior related to misrouted holds (or how the checkin box works when you scan an item that is in transit or on hold and in transit at the wrong library) is now different from what we have version 3.06.00.000 (our production server). Video of canceling a hold from the report and double-scanning it - http://screencast.com/t/zPAeQDHyE Video of misrouting an item on hold - this happens quite often in our large consortium with 4 different libraries starting with 'O'... http://screencast.com/t/VaRZTy8vmFLl Video of misrouting an item on hold in 3.06.00.000, so you can see the difference. Could be related to Bug 6226 or not. http://screencast.com/t/KTYCUWrvCvb Hope that all makes sense... Sharon -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #11 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-05 03:44:17 UTC --- The patch I provided is actually wrong. I think that your problem was actually resolved in master. Can you please confirm that and cancel. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- This appears to have been fixed in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6489 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org