http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15291&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com --- Comment #2 from Melia Meggs <melia@bywatersolutions.com> --- Hi, I applied this patch and did the following tests: 1. Patron A had one item overdue that had both home and holding branch of Centerville. 2. Patron B had one item overdue that had both home and holding branch of Centerville, and one item overdue that had home branch of Rutland and holding branch of Centerville. 3. Patron C had one item overdue that had home branch of Rutland and holding branch of Fairfield. I then used the filters on overdues and found that they gave correct results for item home branch and item holding branch. So I am signing off! However, I do have two questions which could possibly be addressed with a follow up patch: - When looking at overdues, in addition to the item home branch and item holding branch filters that you've added, I also see one for just "Home branch" (with no dropdown menu) as well as one for "Library of the patron." "Library of the patron" is clear and appears to work fine, but I wasn't sure what "Home branch" is supposed to do now that we have a choice of item home branch. Should "Home branch" be removed now? I got no results using Home branch each time that I tried. - When looking at a record (here, for example: http://staff-melia.test.bywatersolutions.com/cgi-bin/koha/catalogue/detail.p...), we have columns for Current Location (the same as holding branch) and Home Library. Should we rename your holding branch filter as Current Location for consistency? Thanks, Melia -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #2)

I also see one for just "Home branch" I do not see this in master version.

Should we rename your holding branch filter as Current Location for consistency? Goof idea for me.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15349|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16804&action=edit [PASSED QA] Bug 9604: filter overdues with homebranch and holdingbranch This patch adds in overdues.pl filters on item home branch and holding branch. Test plan : Play with item home branch and holding branch filters and check it filters well results. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Filters are added to the list of overdues in the circulation module. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16804|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16806&action=edit [PASSED QA] Bug 9604: filter overdues with homebranch and holdingbranch This patch adds in overdues.pl filters on item home branch and holding branch. Test plan : Play with item home branch and holding branch filters and check it filters well results. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Filters are added to the list of overdues in the circulation module. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.