[Bug 13774] New: Add the unique anchors of news as links in the RSS for news in Opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Bug ID: 13774 Summary: Add the unique anchors of news as links in the RSS for news in Opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: viktor.sarge@regionhalland.se QA Contact: testopia@bugs.koha-community.org Bug 7843 introduces an RSS stream for news (currently passed QA) which is valid but don't have a good unique URI of each newsitem for linking purposes. Bug 12729 (pushed) creates unique a unique anchor id for each newsitem and I propose to update the RSS stream with links to these anchors as a first step. The next step would be to create some form of single item view for news and probably a news archive instead of deleting the news when they time out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 --- Comment #1 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 36306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36306&action=edit Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac This patch adds the unique anchors of bugs from bug13729 into the rss stream of the news in opac from bug7843. Since 7843 is already passed QA and I'm new to Git and mess things up I chose to post this update in a separate patch even if it's a tiny change. The addition of a unique guid tag both help users and keeps validators happy. Test plan: * Make sure you are on master in order to get the anchors from bug 13729 (or you could apply it manually). * Apply bug 7843 * Apply this patch. * Make shure you have enough news to make the Opac main page scroll. * Find the RSS link at the bottom om opac main and klick it. * Verify that the link displayed for each newsitem takes you to the right anchor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7843 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre@gmail.com --- Comment #2 from Pierre Angot <tredok.pierre@gmail.com> --- I've tested on sandbox. I've added the RSS on my agregator (Leed). It works correctly, but when I click on a link, I'm not direct to the opac. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Hi Pierre! We discovered that the sandboxes has the opac disabled as public. The RSS stream does link to the correct news item but when the opac require log in you will not be able to see the news. Does the problem persist when you make the opac public in the sysprefs? Another thing to watch our for is that the RSS stream can only expose news that are directed to "all libraries". If you view the news while logged in and only have news directed to a particular library (but none directed to "all libraries" you will get an empty RSS. This need to be handled a bit better, but that's a matter for other patches :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7843 |5010 CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- I added depends on 5010, because there is no hardcoded protocol in this link, which means it will be protocol-less currently. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 --- Comment #5 from Viktor Sarge <viktor.sarge@regionhalland.se> --- We plan to add the ability to pass the id of a news item to (for example) opac-main.pl and if that gets pushed it will likely be better to add this link instead of anchors. But it will still depend on 5010 i guess. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36306|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 46154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46154&action=edit Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac This patch adds the unique anchors of bugs from bug13729 into the rss stream of the news in opac from bug7843. Since 7843 is already passed QA and I'm new to Git and mess things up I chose to post this update in a separate patch even if it's a tiny change. The addition of a unique guid tag both help users and keeps validators happy. Test plan: * Make sure you are on master in order to get the anchors from bug 13729 (or you could apply it manually). * Apply bug 7843 * Apply this patch. * Make shure you have enough news to make the Opac main page scroll. * Find the RSS link at the bottom om opac main and klick it. * Verify that the link displayed for each newsitem takes you to the right anchor. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46154|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46227&action=edit Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac This patch adds the unique anchors of bugs from bug13729 into the rss stream of the news in opac from bug7843. Since 7843 is already passed QA and I'm new to Git and mess things up I chose to post this update in a separate patch even if it's a tiny change. The addition of a unique guid tag both help users and keeps validators happy. Test plan: * Make sure you are on master in order to get the anchors from bug 13729 (or you could apply it manually). * Apply bug 7843 * Apply this patch. * Make shure you have enough news to make the Opac main page scroll. * Find the RSS link at the bottom om opac main and klick it. * Verify that the link displayed for each newsitem takes you to the right anchor. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Viktor! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org