[Bug 5645] New: Z39.50 search from search results not parsing query correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Summary: Z39.50 search from search results not parsing query correctly Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 When searching in only 1 index (kw,wrdl: for example), then clicking the 'Z39.50 Search' button from the search results, the index prefix is not removed from the search term as it's filled into the boxes of the Z39.50 search page. This is not a problem for two or more separate search fields. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #1 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- *** Bug 7471 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #2 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Confirmed, still a bug. See Liz Rea's screenshot from bug 7471 : http://screencast.com/t/Zi2saYeF9sz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #0)
This is not a problem for two or more separate search fields.
I still see this bug in master as of 3.12 beta1, and I don't find the above statement to be true. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabrielle.dusseault@gmail.c | |om --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- *** Bug 10034 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10742 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- The patch for bug 10742 fixes the case when the main search returns no results. I will shortly be attaching a patch that fixes this when the main search *does* return results. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20857&action=edit Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does *not* return any hits in the Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20857|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 21365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21365&action=edit Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does *not* return any hits in the Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Works as advertised. No qa complaints. Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This was missing a sign off when it got QA'd. I am switching back to 'needs signoff' so it gets on the radar of testers. Please switch to 'passed QA' if testing is successful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21705&action=edit Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does *not* return any hits in the Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing status with reference to comment8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org