[Bug 33699] New: Typo in identity_provider_domains.tt (presedence)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Bug ID: 33699 Summary: Typo in identity_provider_domains.tt (presedence) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org In identity_provider_domains.tt, there is a typo in the sentence Exact matches have presedence over wildcard ones, so 'library.com' domain will take presedence over '*library.com' when the email is 'somebody@library.com' "presedence" should be "precedence" in both occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I just noticed there is more than one sentence with the term "presedence". The same way, the longest match will take presedence over the shorter one, so '*teacher.university.com' will take presedence over '*.university.com' if the email is 'user@math.teacher.university.com' Each sentence is repeated twice in the file, for a total of 8 occurrences of "presedence" to correct. I also noticed that one of the sentences has superfluous words. Exact matches have presedence over asterix ones, so if the 'library.com' domain will take presedence over '*library.com' when the email is 'somebody@library.com' "so if the" in the other sentence that is the same is simply "so". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151008&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen for the correction! Does the div vs p affect the space between the lines? I noticed that when adding a new domain, the lines are all smushed together, but when editing an existing domain, the lines are spaced out, making it easier to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Whoops, my patch is incomplete! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151008|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151010&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151010|0 |1 is obsolete| | --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 151017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151017&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151017|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151122&action=edit Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31378 Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Depends on Bug 31378 - Add a generic OAuth2/OIDC client implementation, not in 22.05.x. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org