http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9613&action=edit Bug 7703 - Don't block bulk hold action on search results if some items can't be placed on hold In the staff client if you check multiple lines in search results and click the button to "place hold" you might be blocked from proceeding because "One or more selected items cannot be placed on hold." The next stage of the holds process is perfectly capable of warning the user about such problems. The user should not have to search back through the list of items they checked to find which one to un-check. Fixed by not disabling the submit button in the event that one of the records has no holdable items. Updated text of submit buttons. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- On a tangentially connected note, disabled buttons in Koha appear no different than enabled buttons. We should really have some CSS in Koha to make disabled buttons distinguishable from enabled ones. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think normally we don't show a button, if it is not available. We also hide areas and pages, that are not available because of missing permissions. Links in pull down menus can be greyed out sometimes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Kyle, should the patch on this bug be moved to a new bug and the status of this bug changed back to ASSIGNED? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9613|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 9613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9613 Bug 7703 - Don't block bulk hold action on search results if some items can't be placed on hold Moved to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9336 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14360&action=edit Bug 7703 - Don't block bulk hold action on search results if some items can't be placed on hold Remove the check that prevents submitting a multi-hold if one or more records in the multi-hold have no items. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Test plan: 1) Apply patch 2) On the staff interface, do a search 3) On the search results, select at least one record with items and one record with no items. 4) Click the 'Place hold' button. 5) You should be redirected to reserve/request.pl with the message "Cannot place hold: this record has no items attached." -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14360|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14435&action=edit [SIGNED-OFF] Bug 7703 - Don't block bulk hold action if some items can't be placed on hold If you select multiple titles on the search results page in order to place a bulk hold and some of those titles have no items you get a JavaScript alert warning you can some cannot be placed on hold. You are blocked from completing the action until you deselect the invalid hold. This is unnecessary because the bulk hold process will safely refuse to place a hold on these titles later in the process. This patch removes the check that prevents submitting a multi-hold if one or more records in the multi-hold have no items. Test plan: 1) Apply patch 2) On the staff interface, do a search 3) On the search results, select at least one record with items and one record with no items. 4) Click the 'Place hold' button. 5) You should be redirected to reserve/request.pl with the message "Cannot place hold: this record has no items attached." Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added a description of the problem and copied the test plan from the bug report, fulfilling commit message guidelines. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9350 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Jonathan, I cannot recreate your error. When I try placing a hold on a bib with no items I get the correct behavior as described. Do you think you could provide me with some more info and perhaps re-test it? (In reply to comment #13)

QA Comment:

I got an error:

DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3 at /home/koha/src/C4/Koha.pm line 833.

Debug: request.pl l.320, the @itemnumbers is empty

The issue appears when I place on hold a biblio without item.

Marked as Failed QA.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19114&action=edit Bug 7703 - Don't block bulk hold action if some items can't be placed on hold If you select multiple titles on the search results page in order to place a bulk hold and some of those titles have no items you get a JavaScript alert warning you can some cannot be placed on hold. You are blocked from completing the action until you deselect the invalid hold. This is unnecessary because the bulk hold process will safely refuse to place a hold on these titles later in the process. This patch removes the check that prevents submitting a multi-hold if one or more records in the multi-hold have no items. Test plan: 1) Apply patch 2) On the staff interface, do a search 3) On the search results, select at least one record with items and one record with no items. 4) Click the 'Place hold' button. 5) You should be redirected to reserve/request.pl with the message "Cannot place hold: this record has no items attached." Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added a description of the problem and copied the test plan from the bug report, fulfilling commit message guidelines. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19115&action=edit Bug 7703 - QA Followup -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- I was able to recreate your issue, and I've attached a followup I think will resolve it! (In reply to comment #15)

Created attachment 15290 [details] Biblio without item

Hi Kyle, This biblio contains no item. When I search 'vifs', this title appears on the first page of results. I click on the checkbox and on the "place holds' button. I still got the same error.

reserve/request.pl: I pass into the following if statement: if (!@itemnumbers) { $template->param('noitems' => 1); $biblioloopiter{noitems} = 1; } and just after the GetItemInfosOf routine is called with @itemnumbers which is empty. I think we want to skip the current biblionumber if it does not contain any item. But maybe we want to raise this problem for the user too.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #19)

Moreover, the message "Cannot place hold: this record has no items attached." appears on a blank page (without back button or something else).

This issue does make it Failed QA, because the point of the bug is to make it possible to continue to place a hold on those titles which do have items attached even if the user also selected some which have no items. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28144&action=edit Bug 7703 - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Applying: Bug 7703 - Don't block bulk hold action if some items can't be placed on hold Applying: Bug 7703 - QA Followup Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Items.pm CONFLICT (content): Merge conflict in C4/Items.pm Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- This bug is still valid in master as of 21 Dec 2015. -- You are receiving this mail because: You are watching all bug changes.