[Bug 43257] New: Remove event attributes from circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 Bug ID: 43257 Summary: Remove event attributes from circulation.tt Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 38407 Target Milestone: --- circulation.tt has a couple of "onclick" event attributes which should be moved to checkouts.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- <button class="btn btn-default print" type="submit" accesskey="p" onclick="Dopop('hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]&itemnumber=[% item.id | html %]');this.form.submit();" <button class="btn btn-default print" type="submit" accesskey="p" onclick="Dopop('/cgi-bin/koha/recalls/recall_pickup_slip.pl?recall_id=[% RECALLED.id | html %]');this.form.submit();" <button class="btn btn-default" type="submit" onclick="window.location.href='/cgi-bin/koha/reserve/request.pl?biblionumber=[% itembiblionumber | html %]&borrowernumber=[% patron.borrowernumber | html %]'" <input type="checkbox" id="stickyduedate" onclick="this.form.barcode.focus();" name="stickyduedate" checked="checked" /> <input type="checkbox" id="stickyduedate" onclick="this.form.barcode.focus();" name="stickyduedate" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203417&action=edit Bug 43257: Remove event attributes from circulation.tt This patch updates circulation.tt in order to remove event attributes in favor of defining event handlers in the relevant JS file. To test, apply the patch and clear your cache if necessary. - If necessary, enable the SpecifyDueDate system preference. - Check out to a patron. - Click the checkout settings icon inside the barcode field. - Click the "Specify due date" field's "Remember for session" checkbox - The focus should move to the barcode field. - Enable recalls if necessary - Locate a checked out item which can be recalled. - Log in to the OPAC and recall the item. - In the staff interface, try to check that item out to another patron. - You should get a "Please confirm checkout" message. - Click the "Don't check out and print slip" button. - A popup should open for printing a recall slip. - The checkout page should reload without checking out the item. - If necessary, place a hold on an item for delivery to your logged-in library, check in the item, and confirm the hold. - Try to check out the item to another patron. - You should get a "Please confirm checkout" message. - Click "Don't check out, confirm hold, and print slip" - A popup should open for printing a hold slip. - The checkout page should reload without checking out the item. - If necessary, place a hold on an item but do not check it in. - Try to check out the item to a patron. - You should get a "Please confirm checkout" message. - Click "Cancel checkout and place hold for..." - You should be redirected to the holds page, placing a hold for that patron and that item. - The item should not have gotten checked out in the process. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43257 --- Comment #3 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203837&action=edit Bug 43257: Remove event attributes from circulation.tt This patch updates circulation.tt in order to remove event attributes in favor of defining event handlers in the relevant JS file. To test, apply the patch and clear your cache if necessary. - If necessary, enable the SpecifyDueDate system preference. - Check out to a patron. - Click the checkout settings icon inside the barcode field. - Click the "Specify due date" field's "Remember for session" checkbox - The focus should move to the barcode field. - Enable recalls if necessary - Locate a checked out item which can be recalled. - Log in to the OPAC and recall the item. - In the staff interface, try to check that item out to another patron. - You should get a "Please confirm checkout" message. - Click the "Don't check out and print slip" button. - A popup should open for printing a recall slip. - The checkout page should reload without checking out the item. - If necessary, place a hold on an item for delivery to your logged-in library, check in the item, and confirm the hold. - Try to check out the item to another patron. - You should get a "Please confirm checkout" message. - Click "Don't check out, confirm hold, and print slip" - A popup should open for printing a hold slip. - The checkout page should reload without checking out the item. - If necessary, place a hold on an item but do not check it in. - Try to check out the item to a patron. - You should get a "Please confirm checkout" message. - Click "Cancel checkout and place hold for..." - You should be redirected to the holds page, placing a hold for that patron and that item. - The item should not have gotten checked out in the process. Sponsored-by: Athens County Public Libraries Signed-off-by: Olivia Reynolds <olivia.reynolds@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org