[Bug 13261] New: Better check in message for patrons with indefinite restricition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Bug ID: 13261 Summary: Better check in message for patrons with indefinite restricition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com After checking in an item for patron with an indefinite restriction the checkin message reads: Reminder: Patron was earlier restricted until 9999-12-31 It should be changed to: Reminder: Patron has a restriction (no expiry date) (Same message like after check out with restriction override) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 33593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33593&action=edit Bug 13261 - Better check in message for patrons with indefinite restricition This patch adds a better check in message for patrons with indefinite restriction. To test: Check out an item to a patron. Add a manual restriction without expiry date to that patron. Check in the item. Without patch, the checkin message reads: Reminder: Patron was earlier restricted until 9999-12-31 Apply patch and repeat steps above. The message should now read: Reminder: Patron has a restriction (no expiry date) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Summary|Better check in message for |Better check in message for |patrons with indefinite |patrons with indefinite |restricition |restriction -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33593|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33594&action=edit Bug 13261 - Better check in message for patrons with indefinite restricition This patch adds a better check in message for patrons with indefinite restriction. To test: Check out an item to a patron. Add a manual restriction without expiry date to that patron. Check in the item. Without patch, the checkin message reads: Reminder: Patron was earlier restricted until 9999-12-31 Apply patch and repeat steps above. The message should now read: Reminder: Patron has a restriction (no expiry date) Signed-off-by: Frederic Demians <f.demians@tamil.fr> Thanks Marc for catching this case. I was thinking like you that the wording sounded strange while playing with bug 13242. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I would prefer something like "Patron has an indefinite restriction" Or "Patron is restricted indefinitely." I'm glad to see this worked on--this was a complaint at my library after our recent upgrade. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Owen Leonard from comment #3)
I would prefer something like "Patron has an indefinite restriction" Or "Patron is restricted indefinitely." I'm glad to see this worked on--this was a complaint at my library after our recent upgrade.
Maybe 'permanently'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> ---
Maybe 'permanently'.
'Permanently' implies that the restriction can't be removed. 'Indefinitely' implies that the ending date is simply not known. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 33595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33595&action=edit [Follow-up] Bug 13261 - Better wording for check in message Changed wording at two places following Owen's suggestion. New: "Patron has an indefinite restriction" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Marc Véron <veron@veron.ch> --- Reset to "Needs Signoff" for second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Didier <didier.queneutte@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.queneutte@univ-renne | |s2.fr --- Comment #8 from Didier <didier.queneutte@univ-rennes2.fr> --- Tested on Sandbox 1 (Unimarc) When checking in after adding a restriction without expiry date, ends with a gateway time out (error 504). Check out and check in without restriction work, check in with restriction and expiry date works too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33619&action=edit Bug 13261 - Better check in message for patrons with indefinite restricition This patch adds a better check in message for patrons with indefinite restriction. To test: Check out an item to a patron. Add a manual restriction without expiry date to that patron. Check in the item. Without patch, the checkin message reads: Reminder: Patron was earlier restricted until 9999-12-31 Apply patch and repeat steps above. The message should now read: Reminder: Patron has a restriction (no expiry date) NOTE: Changed wording at two places following Owen's suggestion. New: "Patron has an indefinite restriction" Signed-off-by: Frederic Demians <f.demians@tamil.fr> Thanks Marc for catching this case. I was thinking like you that the wording sounded strange while playing with bug 13242. Merge the original patch and the followup, containing a better wording, thanks to Owen comment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33595|0 |1 is obsolete| | CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Marc, could you add a test to cover the change to AddReturn? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33619|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33630&action=edit [PASSED QA] Bug 13261 - Better check in message for patrons with indefinite restricition This patch adds a better check in message for patrons with indefinite restriction. To test: Check out an item to a patron. Add a manual restriction without expiry date to that patron. Check in the item. Without patch, the checkin message reads: Reminder: Patron was earlier restricted until 9999-12-31 Apply patch and repeat steps above. The message should now read: Reminder: Patron has a restriction (no expiry date) NOTE: Changed wording at two places following Owen's suggestion. New: "Patron has an indefinite restriction" Signed-off-by: Frederic Demians <f.demians@tamil.fr> Thanks Marc for catching this case. I was thinking like you that the wording sounded strange while playing with bug 13242. Merge the original patch and the followup, containing a better wording, thanks to Owen comment. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33944&action=edit Bug 13261: Remove warning if no parameter given Without any parameter, dt_from_string should not raise a warning message. Test plan: Verify that the test file t/DateUtils.t displays a warning: Use of uninitialized value $date_string in pattern match (m//) at Koha/DateUtils.pm line 58 if the change in dt_from_string is not applied (manually edit the file). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33944|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 33944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33944 Bug 13261: Remove warning if no parameter given wrong bug report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #15 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Thanks for the patch Marc! Just stumbled upon this issue having barred some of our patrons :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13532 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13025 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org