https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 145683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145683&action=edit Bug 32731: Use CataloguingToolsInToolsHome This enhancement adds a systempreference CataloguingToolsInToolsHome which, when enabled, also displays the cataloguing tools (now shown on the Cataloguing Home page) on the Tools page, where they were before. To test: 1) Apply database updates 2) Go to Administration -> System preferences. Confirm CataloguingToolsInToolsHome system preference shows under Cataloguing tab. It will be disabled by default 3) Go to the Tools home page. Confirm the 'patrons and circulation' and 'additional tools' menus show as expected. Go to the Cataloguing home pag, click one of the links and notice the cataloguing sidebar. 4) Enable the CataloguingToolsInToolsHome system preference. 5) Go to the Tools home page. Confirm the 'cataloguing' menu shows in the middle. 6) Confirm all of the cataloguing menu links are correct 7) When clicking on one of the 'patrons and circulation' menu or 'additional tools' menu links, confirm the sidebar menu shows the tools sidebar rather than the cataloguing menu. 8) When clicking on one of the 'cataloguing' menu links, confirm it shows the cataloguing sidebar, but there is now a link to the Tools Home Sponsored-by: Educational Services Autralia SCIS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145683|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145753&action=edit Bug 32731: Use CataloguingToolsInToolsHome This enhancement adds a systempreference CataloguingToolsInToolsHome which, when enabled, also displays the cataloguing tools (now shown on the Cataloguing Home page) on the Tools page, where they were before. To test: 1) Apply database updates 2) Go to Administration -> System preferences. Confirm CataloguingToolsInToolsHome system preference shows under Cataloguing tab. It will be disabled by default 3) Go to the Tools home page. Confirm the 'patrons and circulation' and 'additional tools' menus show as expected. Go to the Cataloguing home pag, click one of the links and notice the cataloguing sidebar. 4) Enable the CataloguingToolsInToolsHome system preference. 5) Go to the Tools home page. Confirm the 'cataloguing' menu shows in the middle. 6) Confirm all of the cataloguing menu links are correct 7) When clicking on one of the 'patrons and circulation' menu or 'additional tools' menu links, confirm the sidebar menu shows the tools sidebar rather than the cataloguing menu. 8) When clicking on one of the 'cataloguing' menu links, confirm it shows the cataloguing sidebar, but there is now a link to the Tools Home Sponsored-by: Educational Services Autralia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com Depends on| |31162 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Should not we add a tooltip/info at the top of the page about the change, instead of adding all the links back? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #5)

Should not we add a tooltip/info at the top of the page about the change, instead of adding all the links back?

I think adding a tooltip/info at the top of the Tools home sounds like a more maintainable approach. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #8)

If it doesn't work for you, last resort could be just injecting the entries using a plugin to ease things.

Which could be achieve easily with some JS. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Haven't applied Nick's alternate yet but sounds like a better option. I had thought about moving the HTML to an include so glad I'm not the only one thinking that way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I also have my doubts about this one. I think it could create more issues than be helpful long term and be confusing. The breadcrumbs and page title will still point to the cataloguing home page. The sidebar on the left will also be the cataloguing one. Maybe it would be better to have a clean break? Another option to JS would be creating something similar to IntranetReportsHomeHTML for the Tools start page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #13)

Maybe it would be better to have a clean break?

Makes sense to me. I'm already telling people that those tools have moved from Tools to Cataloguing. No one has complained yet. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150691|0 |1 is obsolete| | --- Comment #16 from Sam Lau <samalau@gmail.com> --- Created attachment 151605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151605&action=edit Bug 32731: Move cataloging tools to an include and show on tools home This patch moves the cataloging tools to an include, which is then added with a toggle to the tools homepage. This allows for the content to be on both pages, and can easily be hidden or shown by default. It ensures we don't have to maintain the same links in two places To test: 1 - Apply patch 2 - Ensure cataloging home page looks the same 3 - Ensure you can view/hide the cataloging tools on the tools page Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like the tools page got really crowded over time and it probably will again. Could a link/button to cataloguing tools do? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157127|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158613&action=edit Bug 32731: Move cataloging tools to an include and show on tools home This patch moves the cataloging tools to an include, which is then added with a toggle to the tools homepage. This allows for the content to be on both pages, and can easily be hidden or shown by default. It ensures we don't have to maintain the same links in two places To test: 1 - Apply patch 2 - Ensure cataloging home page looks the same 3 - Ensure you can view/hide the cataloging tools on the tools page Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158613|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161962&action=edit Bug 32731: Move cataloging tools to an include and show on tools home This patch moves the cataloging tools to an include, which is then added with a toggle to the tools homepage. This allows for the content to be on both pages, and can easily be hidden or shown by default. It ensures we don't have to maintain the same links in two places To test: 1 - Apply patch 2 - Ensure cataloging home page looks the same 3 - Ensure you can view/hide the cataloging tools on the tools page Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> ---

From a UX perspective, having a show/hide link at the bottom just feels wrong to me. The additional cataloging tools no longer crowd the screen because they are below the other tools not beside them. With a CSS class, libraries can easily hide those tools if the wish to. It would be nice if we updated the tools links to the new "big button" style, but that's a discussion for another bug ;)

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Option for cataloguing |Option for cataloguing |tools to also be shown in |tools to also be shown in |Tools Home |tools home Status|Passed QA |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) General I have to admit, I am not a fan of this one. I'll try to explain: * The cataloguing start page was introduced in 22.11. So it's already 1.5 years since the change when this will be released. That's a lot of time to "go back" to previous. * I think there is something in UX about as soon as you have more content than fits on a screen, things get difficult. With this patch applied I can only see the tools preferences unless I scroll down. I wonder if the advantage of having it in 2 places doesn't get negated by that. * There is a style mis-match here between the old and the new which makes it not look less attractive and inconsistent in my opinion. * AND: This makes it appear by default on update, and I am really stuck on that one. If you all insist on having this, I think it should be optional and not appear on update (least change of behavior as the original change was too long ago). If YASP is the way, then it shall be. I know CSS, but you can't set CSS as easily on update, so I think that would be a better compromise here. Open for discussion! 2) Unused code - + <div class="row"> + <div id="cataloging-tools-menu" class="cataloging-tools-menu toggle-ct col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> + [% INCLUDE 'cataloging-tools.inc' %] + </div> + </div> + <script> + $("a.toggle-ct").click(function(){ + $(".toggle-ct").toggle(); + }); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #28)

I agree with Katrin's comments. The previous patches gave the option to enable or disable, so even though I wouldn't choose to enable it, I didn't object to the idea. I don't think it makes sense to do this by default.

I think that the issue of folks looking for the tools in the wrong place is temporary, and we shouldn't get in the habit of offering regressions to interface changes.

+1 -- You are receiving this mail because: You are watching all bug changes.