https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org Patch complexity|--- |Trivial patch Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67194&action=edit Bug 19337: Make basic_workflow.t configurable through ENV This patch makes the basic_workflow.t selenium tests read ENV for the following vars: KOHA_USER KOHA_PASS KOHA_INTRANET_URL SELENIUM_ADDR SELENIUM_PORT to properly configure the running environment. If absent, all variables fallback to current behaviour: KOHA_USER // 'koha' KOHA_PASS // 'koha' KOHA_INTRANET_URL (unchanged) SELENIUM_ADDR // 'localhost' SELENIUM_PORT // 4444 [*] Selenium defaults are documented on the Selenium::Remote::Driver docs. Prerequisites: Make sure you have a working environment for the Selenium tests: - Run: $ sudo apt update $ sudo apt install xvfb firefox-esr To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standal... \ -O /tmp/selenium.jar k$ SELENIUM_PATH=/tmp/selenium.jar k$ Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & k$ DISPLAY=:1 java -jar $SELENIUM_PATH & k$ prove t/db_dependent/selenium/basic_workflow.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/selenium/basic_workflow.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67194|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67200&action=edit Bug 19337: Make basic_workflow.t configurable through ENV This patch makes the basic_workflow.t selenium tests read ENV for the following vars: KOHA_USER KOHA_PASS KOHA_INTRANET_URL SELENIUM_ADDR SELENIUM_PORT to properly configure the running environment. If absent, all variables fallback to current behaviour: KOHA_USER // 'koha' KOHA_PASS // 'koha' KOHA_INTRANET_URL (unchanged) SELENIUM_ADDR // 'localhost' SELENIUM_PORT // 4444 [*] Selenium defaults are documented on the Selenium::Remote::Driver docs. Prerequisites: Make sure you have a working environment for the Selenium tests: - Run: $ sudo apt update $ sudo apt install xvfb firefox-esr To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standal... \ -O /tmp/selenium.jar k$ SELENIUM_PATH=/tmp/selenium.jar k$ Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & k$ DISPLAY=:1 java -jar $SELENIUM_PATH & k$ prove t/db_dependent/selenium/basic_workflow.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/selenium/basic_workflow.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.