[Bug 43377] New: Failure to connect to SIP server due to extra bracket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 Bug ID: 43377 Summary: Failure to connect to SIP server due to extra bracket Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Target Milestone: --- After Bug 42847 was backported to 25.05, we started seeing this error repeatedly in sip-output.log ERROR: can't load appenderclass 'Log::Log4perl::Appender::Screen' Compilation error at /usr/share/perl5/Log/Log4perl/Appender.pm line 58. And could no longer connect to the SIP server externally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Depends on| |42847 Sponsorship status|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42847 [Bug 42847] SIP authentication ignored after initial successful connection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 204071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204071&action=edit Bug 43377: Remove extra bracket from C4/SIP/SIPServer.pm This was added by mistake when backporting Bug 42847 to 25.05.x. To test: Look at the patch and confirm the bracket removed is the right fix for this code. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Adding my sign-off (not able to add sign-off line). Looks OK to me - restores what it should be (code matches what is in the current 25.05.13). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 204190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204190&action=edit RMAINT followup for Bug 42847 - remove extra parentheses Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204071|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Comment on attachment 204071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204071 Bug 43377: Remove extra bracket from C4/SIP/SIPServer.pm
From 6e72946009fe13193f4d6448b170040f0389d99a Mon Sep 17 00:00:00 2001 From: Aleisha Amohia <aleishaamohia@hotmail.com> Date: Tue, 25 Aug 2026 05:35:47 +0000 Subject: [PATCH] Bug 43377: Remove extra bracket from C4/SIP/SIPServer.pm
This was added by mistake when backporting Bug 42847 to 25.05.x.
To test: Look at the patch and confirm the bracket removed is the right fix for this code.
Sponsored-by: Catalyst IT --- C4/SIP/SIPServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/SIPServer.pm index c4fbdecef6a..5c7829ce7cf 100644 --- a/C4/SIP/SIPServer.pm +++ b/C4/SIP/SIPServer.pm @@ -399,8 +399,8 @@ sub telnet_transport { $pwd = get_clean_string($pwd); siplog( "LOG_DEBUG", "telnet_transport 2: uid length %s, pwd length %s", length($uid), length($pwd) );
- if ( exists( $config->{accounts}->{$uid} ) - && ( $pwd eq $config->{accounts}->{$uid}->{password} ) ) + if ( exists( $config->{accounts}->{$uid} ) + && ( $pwd eq $config->{accounts}->{$uid}->{password} ) && C4::SIP::Sip::MsgType::login_core( $self, $uid, $pwd ) ) { $account = $config->{accounts}->{$uid}; -- 2.55.0
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Signed Off |RESOLVED Assignee|aleisha@catalyst.net.nz |wainuiwitikapark@catalyst.n | |et.nz Version(s)| |25.05.14 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43377 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Pushed to 25.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org