[Bug 18514] New: Allow library to search their Koha and Overdrive collections using ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Bug ID: 18514 Summary: Allow library to search their Koha and Overdrive collections using ElasticSearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org Building on the Elasticsearch and Overdrive work, this feature will allow users to run a cronjob to populate their elastic index with collection information from Overdrive. This makes both local Koha records, and Overdrive ones searchable. This bug will add the code to fetch and index the records, and to search and display them in the OPAC Subsequent bugs will add the detail display to the staff side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 62902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62902&action=edit Bug 18514 : Script to fetch records from Overdrive To Test: You must be running Elasticsearch with Koha 1/ Fill in the Overdrive system preferences 2/ run this script 3/ Records should be in ElasticSearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 62903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62903&action=edit Bug 18514 : Adding search capabilities for Overdrive results in Koha To test 1/ Apply the first patch and run the script in it 2/ Search, notice no Overdrive results showing 3/ Search again, now you should get results in the OPAC results page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 62904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62904&action=edit Bug 18514 Fix link on results page, and show overdrive data on detail page To test 1/ Apply the first 2 patches, and run the fetcher script (in patch one) 2/ Search, notice the overdrive results result in a 404 if you click on them 3/ Apply this patch 4/ Search again 5/ Click on a result, you should now be at a detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nate@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I think there are some updates on a git branch that need to be imported here, current code doesn't run -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Actually no there aren't. Have you not been seeing my updates in our WR system Nick? Basically there isn't missing code here, rebuilding elastic search indexes is busted in master. [Request] ** http://localhost:9200 -[400] [mapper_parsing_exception] Failed to parse mapping [data]: The [string] type is removed in 5.0 and automatic upgrade failed because parameters [index_analyzer] are not supported for automatic upgrades. You should now use either a [text] or [keyword] field instead for field [ff7-01-02] This is nothing to do with the overdrive code. As it dies for misc/search_tools/rebuild_elastic_search.pl too. Which is not touched by this. That dies for me on current master, with or without these patches. (As an aside we need to track down why you didnt see the updates) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- I will double check, I may have just missed those and jumped here. A few lines do need fixed though: Koha::ElasticSearch::Indexer; should be Koha::SearchEngine::Elasticsearch::Indexer; Do you have a bug for ES indexing broken? I haven't hit a problem, but maybe I need to refresh my mappings. -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65004&action=edit Bug 18514 - Followup Adjust ES paths Alter fix to retain ID (so records overwrite on re-run) Commit the records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- With a few minor adjustments things are working and records get indexed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65004|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 65858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65858&action=edit Bug 18514 - Followup Adjust ES paths Alter fix to retain ID (so records overwrite on re-run) Commit the records Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62902|0 |1 is obsolete| | Attachment #65858|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 65859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65859&action=edit Bug 18514 : Script to fetch records from Overdrive To Test: You must be running Elasticsearch with Koha 1/ Fill in the Overdrive system preferences 2/ run this script 3/ Records should be in ElasticSearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62903|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 65860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65860&action=edit Bug 18514 : Adding search capabilities for Overdrive results in Koha To test 1/ Apply the first patch and run the script in it 2/ Search, notice no Overdrive results showing 3/ Search again, now you should get results in the OPAC results page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62904|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 65861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65861&action=edit Bug 18514 Fix link on results page, and show overdrive data on detail page To test 1/ Apply the first 2 patches, and run the fetcher script (in patch one) 2/ Search, notice the overdrive results result in a 404 if you click on them 3/ Apply this patch 4/ Search again 5/ Click on a result, you should now be at a detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Component|OPAC |Searching - Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18514 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- If you do get a chance to rebase this. Please ping me I'd be really happy to test it immediately so we don't have to go through another rebase :) The code does look pretty cool though. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org