https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #19 from David Nind <david@davidnind.com> --- I was just been about to say the same (that the patch no longer applies). 8-) I was testing last week, and hadn't finished before it was signed off. I had some suggested text changes - I am happy to add a follow-up once the patches apply again. This is so that it makes more sense if there are multiple reasons for not discharging. Suggested text changes for the OPAC =================================== You cannot be discharged because: . You have unpaid charges of X. Please pay your charges before reapplying. . You have X item(s) checked out. Please return your checked out items before reapplying. . You cannot be discharged for an unknown reason. Please contact library staff for more information. Suggested text changes for the staff interface ============================================== A discharge cannot be generated for this patron because: . The patron has unpaid charges of X. . The patron has X item(s) checked out. . The patron cannot be discharged for an unknown reason. Please review the patron's account to determine why. (Not sure about this one.) The patron has holds. These will be cancelled if the discharge is generated. Testing notes ============= 1. In the staff interface, set up these scenarios for some patrons: - Patron A: check out an item and add a manual fee (I used Henry Acevedo) - Patron B: add a manual fee (I used Mary Burton) - Patron C: check out an item (I used Lisa Charles) - Patron D: add a manual fee (I used Bobbie Middleton) 2. Edit the patrons so that they have a password and that you can log in to their accounts in the OPAC. 3. Set the useDischarge system preference to 'Allow'. 4. Attempt to request a discharge for the patrons (OPAC > You account > Ask for a discharge): - Patron A (Manual fee and a checked out item) (Henry): Message is "You cannot be discharged, you have checked out items. Please return items before asking for a discharge." - Patron B (Manual fee) (Mary): "Ask for a discharge" button is available and a discharge can be requested. Message "Your discharge request has been sent. Your discharge will be available on this page within a few days." - Patron C (A checked out item (Lisa)): Message is "You cannot be discharged, you have checked out items. Please return items before asking for a discharge." 5. Apply the patches and restart everything (restart_all). 6. Attempt to request a discharge for the patrons from their OPAC accounts (OPAC > You account > Ask for a discharge): - Patron A (Manual fee and a checked out item)(Henry): Message is now You cannot be discharged for following reasons: . You have 1 item(s) checked out. Please return them before reapplying. . They have unpaid fines totaling 5.00. Please pay your fines before reapplying. - Patron C (A checked out item) (Lisa): Message is now You cannot be discharged for following reasons: . You have 1 item(s) checked out. Please return them before reapplying. - Patron D (A manual fee)(Bobbie): You cannot be discharged for following reasons: . They have unpaid fines totaling 5.00. Please pay your fines before reapplying. 7. Attempt to discharge the patrons from the staff interface, from their patron account: - Patron A (Manual fee and a checked out item)(Henry): Message is now Cannot edit discharge for following reasons: . They have 1 item(s) checked out . They have unpaid fines totaling 5.00 - Patron C (A checked out item) (Lisa): Message is now Cannot edit discharge for following reasons: . They have 1 item(s) checked out - Patron D (A manual fee)(Bobbie): Cannot edit discharge for following reasons: . They have unpaid fines totaling 5.00 OPAC discharge text =================== I've created bug 37729 for the discharge text on the OPAC "Ask for a discharge" page, suggesting that this is changed to an HTML customization - so that the text can be customised and translated. Current hard coded text ----------------------- Discharge What is a discharge? This document certifies that you have returned all borrowed items. It is sometimes asked during a file transfer from a school to another. The discharge is sent by us to your school. You will also find it available on your reader account. Warning: This request is only valid if you are in good standing with the library. Once the application is made, you can not borrow library materials. -- You are receiving this mail because: You are watching all bug changes.