[Bug 26218] New: When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Bug ID: 26218 Summary: When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #1 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108307&action=edit Screenshot1 When a patron is created or edited from OPAC and the date of birth is invalid it is not giving any alert message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108308&action=edit Screenshot2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When a patron is created or |When a patron is created or |edited from OPAC and the |edited from OPAC and the |date of birth is invalid it |date of birth is invalid it |is not giving any alert |showing in the date of |message |birth text box even text | |box focus is out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When a patron is created or |When a patron is created or |edited from OPAC and the |edited from OPAC and the |date of birth is invalid it |date of birth is invalid it |showing in the date of |showing invalid date of |birth text box even text |birth in the text box even |box focus is out. |if text box focus is out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108334&action=edit Bug 26218: When a patron is created or edited from OPAC and the date of birth is invalid it showing invalid date of birth in the text box even if text box focus is out To Test: 1. Create the patron category from the staff page for ex: ST 2. Set PatronSelfRegistration to allow. 3. Allow category in PatronSelfRegistrationDefaultCategory for online registration from opac. 4. Go to /cgi-bin/koha/opac-memberentry.pl page. 5. Fill the form and give any invalid date and it show invalid date of birth in the date of birth text box even if text box focus is out. 6. Apply the patch. 7. Go to /cgi-bin/koha/opac-memberentry.pl page. 8. Fill the form and give any invalid date and it show blank value in the date of birth text box once text box focus is out. ------------------------------------------------- This patch will work for both new or edit patron from the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #4 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108335&action=edit Bug 26218: Added jquery validation in opac-reserve.pl page for calendar icon. To Test: 1. Search the catalog record in the OPAC. 2. Click on place hold 3. Go to /cgi-bin/koha/opac-reserve.pl?biblionumber=xxx 4. Click on Show more option. Calender icon is not coming. 5. Apply the patch. 6. Click on Show more option. Now you can able to see the calender icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26211 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When a patron is created or |Add JavaScript validation |edited from OPAC and the |to date of birth field in |date of birth is invalid it |OPAC registration form |showing invalid date of | |birth in the text box even | |if text box focus is out | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- With these patches applied the date field doesn't seem to work at all on the patron entry form. If I use the datepicker the field is not populated with any data. If I manually type a number it is cleared when I tab away from the field. I'm not sure what the second patch is supposed to do. I see the calendar icon in master, and adding the validation plugin isn't going to change anything about how the datepicker works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Owen Leonard from comment #5)
With these patches applied the date field doesn't seem to work at all on the patron entry form. If I use the datepicker the field is not populated with any data. If I manually type a number it is cleared when I tab away from the field.
I'm not sure what the second patch is supposed to do. I see the calendar icon in master, and adding the validation plugin isn't going to change anything about how the datepicker works.
Hi Owen, I have checked and patch is working OK and not found any issue in date of birth field. I am using the same javascript which we are using on the staff interface for the date of birth field. I have applied the patch and not found any issue. You can also check with the below URL. http://52.172.128.94:9093/cgi-bin/koha/opac-memberentry.pl Second patch is related to first patch. After applying the first patch I noticed calendar icon is not visible in opac-reserve.pl page. I did the fix and added [% Asset.js("lib/jquery/plugins/jquery.validate.min.js") | $raw %] to show the calendar icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Brandon J <brandon.jimenez@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #7 from Brandon J <brandon.jimenez@inlibro.com> --- Created attachment 108657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108657&action=edit Bug 26218: Added jquery validation in opac-reserve.pl page for calendar icon. To Test: 1. Search the catalog record in the OPAC. 2. Click on place hold 3. Go to /cgi-bin/koha/opac-reserve.pl?biblionumber=xxx 4. Click on Show more option. Calender icon is not coming. 5. Apply the patch. 6. Click on Show more option. Now you can able to see the calender icon. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brandon.jimenez@inlibro.com --- Comment #8 from Amit Gupta <amitddng135@gmail.com> --- Hi Brandon, Thanks for looking the patch and testing. You have checked only patch and you look into the other one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #9 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Amit Gupta from comment #8)
Hi Brandon,
Thanks for looking the patch and testing. You have checked only patch and you look into the other one.
Hi Brandon, Thanks for looking the patch and testing. You have checked only patch can you look into the other one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Brandon, please check your process for signing off bugs with mulitple patches - we need the sign-off lines on all patches and the old ones to be marked obsolete. Git bz can help you with all that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Amit, I have checked the patches here: 1) Change for date of birth I can replicate the error Owen describes when I change the dateformat to dd.mm.yyyy. I click on the datepicker, select a date, but the input field remains empty. It works without the patch. This works as described for mm/dd/yyyy, but I feel like this would be irritating to users. I'd prefer if we displayed a validation error "Date is invalid, please enter a correct date" or similar. 2) Change to opac-reserve.pl I think this would be a separate problem for another bug and should be moved if necessary. But that said, I cannot replicate the problem you describe. :( I have checked the opac-reserve.pl page on master: - Place hold - More options - Calendar icon on "Hold not needed after:" shows and works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this bug was invalidaed by our move to flatpickr. Please reopen if you disagree! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org