[Bug 10510] New: OPAC's renew selected link has glitchy icon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Bug ID: 10510 Summary: OPAC's renew selected link has glitchy icon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Created attachment 19244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19244&action=edit Screenshot of the affected image The OPAC image sprite lacks enough whitespace between the "renew selected" image and the following image to display correctly, resulting in a glitchy-looking image. The sprite should be modified to make more room. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19246&action=edit Bug 10510 - OPAC's renew selected link has glitchy icon The "renew selected" link on the list of a user's checkouts looks bad because the next icon in the sprite shows through. This patch modifies the sprite to give it proper spacing and corrects the CSS to accommodate the change. To test, apply the patch, clear your browser cache, and view the following pages to confirm that the change works: - With TagsEnabled and TagsInputOnList enabled, view a search results page when logged in and when not logged in. Tag links should be styled correctly. - With OpacBrowseResults enabled, open the detail page for any record and click the "browse shelf" link. The "forward" and "back" arrows should be styled correctly. - With OpacRenewalAllowed enabled, log in to the OPAC and view your checked out items. The "renew selected" and "renew all" links should look correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19246|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19290&action=edit Bug 10510 - OPAC's renew selected link has glitchy icon The "renew selected" link on the list of a user's checkouts looks bad because the next icon in the sprite shows through. This patch modifies the sprite to give it proper spacing and corrects the CSS to accommodate the change. To test, apply the patch, clear your browser cache, and view the following pages to confirm that the change works: - With TagsEnabled and TagsInputOnList enabled, view a search results page when logged in and when not logged in. Tag links should be styled correctly. - With OpacBrowseResults enabled, open the detail page for any record and click the "browse shelf" link. The "forward" and "back" arrows should be styled correctly. - With OpacRenewalAllowed enabled, log in to the OPAC and view your checked out items. The "renew selected" and "renew all" links should look correct. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I can't get this to work for me. I have tested in Firefox and Chromium, deleting my browser cache and it still shows the little bit from the other icon. :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This works for me in several different browsers, so I'm not sure what is going on. If you don't mind, please try pulling up the image itself in the browser and refreshing that: /opac-tmpl/prog/images/sprite.png And if it still isn't working please post a screenshot with browser info. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Will retest - thx for providing the URL :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19290|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19324&action=edit [PASSED QA] Bug 10510 - OPAC's renew selected link has glitchy icon The "renew selected" link on the list of a user's checkouts looks bad because the next icon in the sprite shows through. This patch modifies the sprite to give it proper spacing and corrects the CSS to accommodate the change. To test, apply the patch, clear your browser cache, and view the following pages to confirm that the change works: - With TagsEnabled and TagsInputOnList enabled, view a search results page when logged in and when not logged in. Tag links should be styled correctly. - With OpacBrowseResults enabled, open the detail page for any record and click the "browse shelf" link. The "forward" and "back" arrows should be styled correctly. - With OpacRenewalAllowed enabled, log in to the OPAC and view your checked out items. The "renew selected" and "renew all" links should look correct. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: this will fix only the prog theme, but not the ccsr theme. And it works perfectly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org