[Bug 5963] New: Acquisitions: Add the capability to have a filter by active budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Bug #: 5963 Summary: Acquisitions: Add the capability to have a filter by active budget Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Blocks: 5580 The sub GetBudgetHierarchy return aqbudgetperiods.budget_period_active to have acces to a new filtering way, more the neworderempty.pl page have a check box "shox all". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-28 01:50:46 UTC --- Created attachment 3453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3453 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-31 13:15:24 UTC --- Created attachment 3571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3571 Screenshot The 'Show all' label is placed to the left of dropdown list instead of the right. Can someone confirms this behavior? because i don't see any errors in the template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-03-31 13:42:42 UTC --- To solve the layout problem I recommend replacing this markup at line 314 of neworderempty.tmpl: <span class="label"> Show all :</span><input type="checkbox" id="showallbudgets" /> ...with this: <label for="showallbudgets" style="float:none;width:auto;"> Show all: </label><input type="checkbox" id="showallbudgets" /> Is this checkbox supposed to trigger the display of inactive funds? It didn't do anything at all for me, but I suspect I don't have the right kind of budgets set up to properly test. Please provide more details about how to test this properly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-31 14:04:43 UTC --- Checkbox does nothing, because GetBudgetHierarchy returns only active funds. I will submit a follow up patch with this modification, and Owen's fix for layout. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-31 14:14:49 UTC --- Created attachment 3573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3573 Follow up patch This patch modify GetBudgetsHierarchy to returns all funds, not anly those that are parts of an active budget, and fix a layout problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-31 14:29:56 UTC --- Created attachment 3576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3576 Follow up patch Remove useless comments -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3453|0 |1 is obsolete| | Attachment #3573|0 |1 is obsolete| | Attachment #3576|0 |1 is obsolete| | --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-03 23:19:29 UTC --- This bug is mentioned in: Bug 5963 : Add the ability to filter budgets using the active column http://lists.koha-community.org/pipermail/koha-patches/2011-March/014250.htm... Bug 5963: Modify GetBudgetsHierarchy to returns all funds http://lists.koha-community.org/pipermail/koha-patches/2011-March/014399.htm... Bug 5963: follow up: Remove useless comments http://lists.koha-community.org/pipermail/koha-patches/2011-March/014400.htm... --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-04 09:45:27 UTC --- Created attachment 3610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3610 Sqashed all 3 patches into one -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-05 02:58:43 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6051 CC| |alex.arnaud@biblibre.com --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-04-05 08:56:09 UTC --- *** Bug 6051 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5963 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org