[Bug 39350] New: The language switch is not displayed at the bottom of ERM module pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Bug ID: 39350 Summary: The language switch is not displayed at the bottom of ERM module pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com If the staff interface is available in several language, a langage switch is displayed at the bottom ok Koha's page (id=i18nMenu). It is not displayed at the bottom of ERM pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38664 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179379&action=edit Bug 39350: (bug 38664 follow-up) Restore language selector for Vue.js module ERM and Preservation modules have lost the language selector during the tidy work. There has been a closing div added to the "home" files, which broke the HTML structure. Test plan: Have more than one language selected for StaffInterfaceLanguages. Go to the ERM and Preservation module and confirm that with this patch applied the language selector menu is displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- This works as per the test plan. However: - the language selector is displayed on the ERM and preservation module pages only if the language selected is English. - if you change the language, say to Deutsch, the language selector is no longer shown on the ERM and preservation module pages. Steps to replicate (with the patch applied): 1. Apply the patch. 2. Rebuild things: yarn install 3. Enable the ERM and preservation modules - set these system preferences to "Enable": - ERMModule - PreservationModule 4. Install a language: koha-translate --install de-DE --dev kohadev 5. Restart everything: restart_all 6. Enable the language installed in the StaffInterfaceLanguages system preference. 7. Check that the language selector (English Deutsch) is visible at the bottom of these pages: - Home page - ERM module page - Preservation module page 8. Change the language. 9. Repeat step 7 and note that the language selector is only visible on the home page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- It is working for me. Could you try `yarn js:build` at step 2 (instead of `yarn install`). `install` won't regenerate the assets, only install the node modules (in the node_modules directory) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #3)
It is working for me. Could you try `yarn js:build` at step 2 (instead of `yarn install`).
`install` won't regenerate the assets, only install the node modules (in the node_modules directory)
Thanks Jonathan, that did the trick! Sign off on the way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179379|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 179427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179427&action=edit Bug 39350: (bug 38664 follow-up) Restore language selector for Vue.js module ERM and Preservation modules have lost the language selector during the tidy work. There has been a closing div added to the "home" files, which broke the HTML structure. Test plan: Have more than one language selected for StaffInterfaceLanguages. Go to the ERM and Preservation module and confirm that with this patch applied the language selector menu is displayed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This restores the language release notes| |selector at the bottom of | |the pages for the ERM and | |preservation modules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179427|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180242&action=edit Bug 39350: (bug 38664 follow-up) Restore language selector for Vue.js module ERM and Preservation modules have lost the language selector during the tidy work. There has been a closing div added to the "home" files, which broke the HTML structure. Test plan: Have more than one language selected for StaffInterfaceLanguages. Go to the ERM and Preservation module and confirm that with this patch applied the language selector menu is displayed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 --- Comment #9 from David Nind <david@davidnind.com> --- Bug fix, no change to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39350 Bug 39350 depends on bug 38664, which changed state. Bug 38664 Summary: Tidy the whole codebase https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org