[Bug 7802] New: A MySQLism is used to get the current date.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Priority: P5 - low Change sponsored?: --- Bug ID: 7802 Assignee: gmcharlt@gmail.com Summary: A MySQLism is used to get the current date. QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: marc@msys.ch Hardware: All Status: NEW Version: unspecified Component: Database Product: Koha To get todays date, the MySQL only function CURDATE() or CURRENT_DATE() is being used in many places. Neither CURDATE() nor CURRENT_DATE() must be used, but instead the standard form CAST(now() AS date). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Marc Balmer <marc@msys.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7365 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #1 from Marc Balmer <marc@msys.ch> --- Created attachment 8526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8526&action=edit Remove CUR_DATE() and CURRENT_DATE() MySQLism -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Marc Balmer <marc@msys.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Marc Balmer <marc@msys.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8526|0 |1 is obsolete| | --- Comment #2 from Marc Balmer <marc@msys.ch> --- Created attachment 8616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8616&action=edit Remove date MySQLism Re-created the patch because the first version accidentally added trailing whitespace. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Marc Balmer <marc@msys.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Marc Balmer <marc@msys.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8616|0 |1 is obsolete| | --- Comment #3 from Marc Balmer <marc@msys.ch> --- Created attachment 8901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8901&action=edit Update patch tto remove a MySQLism Updated patch to reflect recent changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8901|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8952&action=edit Bug 7802: [SIGNED-OFF] Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8953&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date) The precedent patch forgot an occurrence in C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- In the first patch, changes in C4/Overdues.pm from NOW() to CAST(now() as DATE) are no longer equivalent since the introduction of hourly loans. date_due is now a datetime, so the check on NOW() should not be cast. Marking first patch Failed QA. Will address second patch after this has been fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19643&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19644&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8952|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #7)
Created attachment 19643 [details] [review] Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date).
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Jonathan: Is this still waiting for Sign Off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to David Cook from comment #9)
Jonathan: Is this still waiting for Sign Off?
David, Yes, the followup needs a signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19643|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20057&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19644|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20058&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #12)
Created attachment 20058 [details] [review] Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date).
Kyle, you forgot to add the Signed-off-by line to the second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20058|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20733&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do we have a reference about CURRENT_DATE being a mysqlism? I found it here: http://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt Also bit worried about changing all those statements without tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #15)
Do we have a reference about CURRENT_DATE being a mysqlism? I found it here: http://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt
At least, it does not work with PostgreSQL: postgres=# select CURRENT_DATE(); ERREUR: erreur de syntaxe sur ou près de « ( » LIGNE 1 : select CURRENT_DATE(); ^ postgres=# select current_date; date ------------ 2013-09-09
Also bit worried about changing all those statements without tests.
I don't have the time to provide unit tests for all modified routines. But MariaDB [koha_devstetienne]> select CURRENT_DATE(); +----------------+ | CURRENT_DATE() | +----------------+ | 2013-09-09 | +----------------+ 1 row in set (0.00 sec) MariaDB [koha_devstetienne]> SELECT CAST(now() AS date); +---------------------+ | CAST(now() AS date) | +---------------------+ | 2013-09-09 | +---------------------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Weird, it's in the Postgres documentation too? http://www.postgresql.org/docs/8.1/static/functions-datetime.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #17)
Weird, it's in the Postgres documentation too? http://www.postgresql.org/docs/8.1/static/functions-datetime.html
Yes select current_date; -- works select current_date(); -- does not work -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- back to need QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20057|0 |1 is obsolete| | Attachment #20733|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22755&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22756&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt@gmail.com |marc@msys.ch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I see the following change: - AND reserves.reservedate <= DATE_ADD(NOW(),INTERVAL ? DAY) + AND reserves.reservedate <= CAST(now() AS date) Fixing a so detested mysqlism should at least preserve functionality. These changes seem to be made in a hurry, since we are changing functionality here. Here you change a date_add with just a now. The parameter for adding a number of days is just ignored. This change was a red traffic light for me :) I did not look any further.. Please correct and add a (more detailed) test plan for this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #22)
I see the following change:
- AND reserves.reservedate <= DATE_ADD(NOW(),INTERVAL ? DAY) + AND reserves.reservedate <= CAST(now() AS date)
Fixing a so detested mysqlism should at least preserve functionality. These changes seem to be made in a hurry, since we are changing functionality here.
No, not the changes, but the rebase yes. Only the last patch introduces this bad conflict merge. I consider after 3 rebase and 1 year, the rebase is not safe at all, there is here a good example...
Here you change a date_add with just a now. The parameter for adding a number of days is just ignored. This change was a red traffic light for me :) I did not look any further..
Please correct and add a (more detailed) test plan for this patch.
There is no valid test plan. Check that the CUR_DATE(), CURRENT_DATE() mysql functions return the same as CAST(NOW() AS DATE) in your mysql cli. Your can verify, looking at the diff code, the patch is correct. If you want to test, you can play with reserves and holds queue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22755|0 |1 is obsolete| | Attachment #22756|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22760&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22761&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22760|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22816&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22761|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22817&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #28 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 22817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22817 Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Review of attachment 22817: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7802&attachment=22817) ----------------------------------------------------------------- ::: C4/Koha.pm @@ +1431,4 @@
# Fall through... we also return a random quote as a catch-all if all else fails } else { + $query = 'SELECT * FROM quotes WHERE timestamp LIKE CONCAT(CAST(now() AS date),\'%\') ORDER BY timestamp DESC LIMIT 0,1';
Ironically, PostgreSQL will happily accept CURRENT_DATE (without the parentheses). It won't accept "LIMIT 0,1". It also won't like trying to compare a timestamp to a string datatype. Closer to the mark (as in, I've actually tested this on both MariaDB and Pg is "select * from quotes where cast(now() as date) = cast(timestamp as date) limit 1 offset 0;" A broader point: I don't think that the point should be to search-and-replace fragments of non-portable SQL. Actually ensuring that the output is portable would be more on target. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #29 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 22816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22816 Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Review of attachment 22816: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7802&attachment=22816) ----------------------------------------------------------------- ::: misc/cronjobs/longoverdue.pl @@ +130,5 @@
SELECT items.itemnumber, borrowernumber, date_due FROM issues, items WHERE items.itemnumber = issues.itemnumber + AND DATE_SUB(CAST(now() AS date), INTERVAL ? DAY) > date_due + AND DATE_SUB(CAST(now() AS date), INTERVAL ? DAY) <= date_due
DATE_SUB() is not portable to PostgreSQL. As implied by my previous comment, I'm much more interested in seeing patches that provably improve portability of the SQL, not ones that just search-and-replace. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt@gmail.com --- Comment #30 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Jonathan Druart from comment #16)
I don't have the time to provide unit tests for all modified routines.
And I don't have the inclination to push a patch series that touches a bunch of routines without adequate test coverage, particularly (as my two immediately previous comments indicate) as it includes at least one case where it has the effective of making it harder to tell that a particular SQL statement is not portable. Setting to failed QA. Feel free to resubmit a partial patch that covers routines that have test cases, and feel free to write UTs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22816|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|marc@msys.ch |gmcharlt@gmail.com --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't plan to provide a better way to fix this. I reset the assignee to default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Tom M <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis@yahoo.com --- Comment #32 from Manos PETRIDIS <egpetridis@yahoo.com> --- Wouldn't a user_defined_function be better suited to the task? One could create a koha_getdate() or even a koha_getdatetime() and they would only need be be changed once, depending on RDBMS used, until koha starts using a db abstraction layer that is. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org