[Bug 39761] New: OPAC DataTables responsive table controls style broken by Bug 39600
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Bug ID: 39761 Summary: OPAC DataTables responsive table controls style broken by Bug 39600 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 39600 Bug 39600 added global inclusion of datatables.min.css to the OPAC's doc-head-close.inc after our opac.css, meaning it overrides our CSS instead of vice versa. Previously datatables.min.css wasn't included globally in the OPAC because so few tables use DataTables. The styling we need is in _tables.scss. I'm not sure what CSS was missing when 39600 was implemented, but we need to either add the required CSS to _tables.scss or rework our implementation of DataTables CSS. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 [Bug 39600] Use the API to render the OPAC ILL requests table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39698 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #0)
Previously datatables.min.css wasn't included globally in the OPAC because so few tables use DataTables. The styling we need is in _tables.scss.
To expand on that a little: Because we needed to style so few DataTables controls it was easier to add a little bit of custom CSS to ours instead of needing to add a lot of CSS in order to customize *and* override the default DataTables styling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could you provide a patch? Trying to get the lose ends in order that seem to pop up everywhere... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181647&action=edit Bug 39761: OPAC DataTables responsive table controls style broken by Bug 39600 This patch copies and adapts some CSS from the default DataTables CSS in order to add to the OPAC the required styles for new features added by the updated ILL request page: Paging, table information, and the "Processing" message shown while the table loads. To test, apply the patch and rebuild the OPAC CSS. You should have ILL enabled and configured. - Log in to the OPAC as a user who has submitted multiple ILL requests. - From the user summary page, click "Interlibrary loan requests" in the left-hand sidebar. - The table of ILL requests should look correct with legible information and controls. - All the DataTable features should work: Paging, showing different numbers of entries per page, sorting. - Go to the user summary page and confirm that the tables on that page still display correctly: Checkouts, overdues, holds, etc. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39600 |39762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 [Bug 39600] Use the API to render the OPAC ILL requests table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39762 [Bug 39762] Add datatables server-side rendering to OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181647|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 181659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181659&action=edit Bug 39761: OPAC DataTables responsive table controls style broken by Bug 39600 This patch copies and adapts some CSS from the default DataTables CSS in order to add to the OPAC the required styles for new features added by the updated ILL request page: Paging, table information, and the "Processing" message shown while the table loads. To test, apply the patch and rebuild the OPAC CSS. You should have ILL enabled and configured. - Log in to the OPAC as a user who has submitted multiple ILL requests. - From the user summary page, click "Interlibrary loan requests" in the left-hand sidebar. - The table of ILL requests should look correct with legible information and controls. - All the DataTable features should work: Paging, showing different numbers of entries per page, sorting. - Go to the user summary page and confirm that the tables on that page still display correctly: Checkouts, overdues, holds, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181659|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181662&action=edit Bug 39761: OPAC DataTables responsive table controls style broken by Bug 39600 This patch copies and adapts some CSS from the default DataTables CSS in order to add to the OPAC the required styles for new features added by the updated ILL request page: Paging, table information, and the "Processing" message shown while the table loads. To test, apply the patch and rebuild the OPAC CSS. You should have ILL enabled and configured. - Log in to the OPAC as a user who has submitted multiple ILL requests. - From the user summary page, click "Interlibrary loan requests" in the left-hand sidebar. - The table of ILL requests should look correct with legible information and controls. - All the DataTable features should work: Paging, showing different numbers of entries per page, sorting. - Go to the user summary page and confirm that the tables on that page still display correctly: Checkouts, overdues, holds, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39761 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 39762 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org